Add node address to log messages with connection errors #1342

New issue

Closed

opened 2024-08-29 06:33:57 +00:00 by anikeev-yadro · 2 comments

anikeev-yadro commented

2024-08-29 06:33:57 +00:00

Member

For better triage process need to add addres of node which drop connection in log messages.
Example message with error:

авг 27 14:03:40 yolorock-node4 frostfs-node[191032]: 2024-08-27T14:03:40.758Z        warn        get/assemble.go:54        failed to assemble splitted object        {"component": "Object.Get service", "request": "GET", "address": "4Ez3ysNNJMoh73JRgRtxsdjYwbbtGCynfvU9jPdWJcJA/9RCjiYDkMNNLZqqcqUeE9ipgw1iVVhRVwKqwxxGudDJ", "raw": false, "local": false, "with session": false, "with bearer": true, "error": "rpc error: code = Unavailable desc = transport is closing", "range_offset": 0, "range_length": 0}

For better triage process need to add addres of node which drop connection in log messages. Example message with error: ``` авг 27 14:03:40 yolorock-node4 frostfs-node[191032]: 2024-08-27T14:03:40.758Z warn get/assemble.go:54 failed to assemble splitted object {"component": "Object.Get service", "request": "GET", "address": "4Ez3ysNNJMoh73JRgRtxsdjYwbbtGCynfvU9jPdWJcJA/9RCjiYDkMNNLZqqcqUeE9ipgw1iVVhRVwKqwxxGudDJ", "raw": false, "local": false, "with session": false, "with bearer": true, "error": "rpc error: code = Unavailable desc = transport is closing", "range_offset": 0, "range_length": 0} ```

anikeev-yadro added the

triage

label 2024-08-29 06:33:57 +00:00

fyrchik added the

frostfs-node

label 2024-08-29 12:35:19 +00:00

fyrchik added the

observability

label 2024-09-12 13:09:56 +00:00

fyrchik commented

2024-09-12 13:10:38 +00:00

Owner

I think the best way to do this is to add wrapping in multiClient, when returning an error.
We use multiclient everywhere.

I think the best way to do this is to add wrapping in `multiClient`, when returning an error. We use multiclient everywhere.

fyrchik added this to the v0.43.0 milestone 2024-09-13 13:13:18 +00:00

achuprov was assigned by fyrchik

2024-09-13 13:13:28 +00:00

fyrchik commented

2024-09-13 13:13:45 +00:00

Owner

Discuss it with @acid-ant and @dstepanov-yadro then do

fyrchik modified the milestone from v0.43.0 to v0.44.0

2024-09-30 11:51:30 +00:00

fyrchik changed title from ~~Enhance log messages with connection errors. Add addresses of nodes~~ to Add node address to log messages with connection errors

2024-10-02 06:31:49 +00:00

achuprov referenced this issue from a pull request that will close it,

2024-10-14 11:07:09 +00:00

node/multiClient: Add node address to errors #1428

fyrchik closed this issue

2024-10-15 14:05:35 +00:00

fyrchik referenced this issue from a commit

2024-10-15 14:05:36 +00:00

[#1342] network/cache: Add node address to error multiClient