TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

node/multiClient: Add node address to errors #1428

Merged
fyrchik merged 1 commit from achuprov/frostfs-node:feat/multiClient_node_address into master 2024-10-15 14:05:34 +00:00
Conversation 0 Commits 1 Files changed 1 +5 -4
achuprov commented 2024-10-14 11:07:09 +00:00
Member
Copy link

Close #1342

Before:

s04  | warn     get/assemblerec.go:266  unable to head parts of the erasure-encoded object      {"component": "Object.Get service", "request": "GET", "address": "AvBXnfcru1hvoiVsJ52sTWxQbGBpdTrqXiGRHgA79ab9/74jQPQaix3yeKSQ3DKxQGmd4TzQArrBTzDeS1uW7ZoJd", "raw": false, "local": true, "with session": false, "with bearer": false, "node": "02ac920cd7df0b61b289072e6b946e2da4e1a31b9ab1c621bb475e30fa4ab102c3", "error": "read object header from FrostFS: write request: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp 192.168.130.73:8080: connect: connection refused\""}

After:

s01  | warn     get/assemblerec.go:266  unable to head parts of the erasure-encoded object      {"component": "Object.Get service", "request": "GET", "address": "Hppm9RYu2HvG69WSv1ABtcFXJ8EdHV4mC7VUAXcw8GBG/bmojABbdKF4DjDTs4uUWM4Z6k86CQP7NjZf2yHaZsz2", "raw": false, "local": true, "with session": false, "with bearer": false, "node": "02ac920cd7df0b61b289072e6b946e2da4e1a31b9ab1c621bb475e30fa4ab102c3", "error": "read object header from FrostFS: client error at /dns4/s03.frostfs.devenv/tcp/8080: write request: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp 192.168.130.73:8080: connect: connection refused\""}

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #1342 Before: ``` s04 | warn get/assemblerec.go:266 unable to head parts of the erasure-encoded object {"component": "Object.Get service", "request": "GET", "address": "AvBXnfcru1hvoiVsJ52sTWxQbGBpdTrqXiGRHgA79ab9/74jQPQaix3yeKSQ3DKxQGmd4TzQArrBTzDeS1uW7ZoJd", "raw": false, "local": true, "with session": false, "with bearer": false, "node": "02ac920cd7df0b61b289072e6b946e2da4e1a31b9ab1c621bb475e30fa4ab102c3", "error": "read object header from FrostFS: write request: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp 192.168.130.73:8080: connect: connection refused\""} ``` After: ``` s01 | warn get/assemblerec.go:266 unable to head parts of the erasure-encoded object {"component": "Object.Get service", "request": "GET", "address": "Hppm9RYu2HvG69WSv1ABtcFXJ8EdHV4mC7VUAXcw8GBG/bmojABbdKF4DjDTs4uUWM4Z6k86CQP7NjZf2yHaZsz2", "raw": false, "local": true, "with session": false, "with bearer": false, "node": "02ac920cd7df0b61b289072e6b946e2da4e1a31b9ab1c621bb475e30fa4ab102c3", "error": "read object header from FrostFS: client error at /dns4/s03.frostfs.devenv/tcp/8080: write request: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp 192.168.130.73:8080: connect: connection refused\""} ``` Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2024-10-14 11:07:10 +00:00
[#1342] node/multiClient: Add node address to errors
All checks were successful
DCO action / DCO (pull_request) Successful in 1m10s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m50s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m43s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m46s
Details
Build / Build Components (pull_request) Successful in 3m1s
Details
Tests and linters / gopls check (pull_request) Successful in 3m5s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m8s
Details
Tests and linters / Lint (pull_request) Successful in 3m55s
Details
Tests and linters / Tests (pull_request) Successful in 6m38s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m45s
Details
d5a3f6056c 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from storage-core-committers 2024-10-14 11:07:48 +00:00
achuprov requested review from storage-core-developers 2024-10-14 11:07:53 +00:00
achuprov force-pushed feat/multiClient_node_address from d5a3f6056c to 682e04f780 2024-10-14 11:08:56 +00:00 Compare
dstepanov-yadro approved these changes 2024-10-14 11:15:08 +00:00
Dismissed
a-savchuk approved these changes 2024-10-14 11:21:42 +00:00
Dismissed
fyrchik approved these changes 2024-10-14 11:23:17 +00:00
Dismissed
fyrchik left a comment
Owner
Copy link

Please, change node/multiClient to network/cache.

Please, change `node/multiClient` to `network/cache`.
pkg/network/cache/multi.go Outdated
@ -170,2 +170,4 @@
var eiErr *objectSDK.ECInfoError
if err != nil {
err = fmt.Errorf("client error at %v: %w", addr, err)
fyrchik commented 2024-10-14 11:22:40 +00:00
Owner
Copy link

What does client error mean in logs?

What does `client error` mean in logs?
fyrchik commented 2024-10-14 15:19:21 +00:00
Owner
Copy link

how about connect to %v: %w
I am sure the error will already be mentioned multiple times in the full message.

how about `connect to %v: %w` I am sure the `error` will already be mentioned multiple times in the full message.
fyrchik requested review from fyrchik 2024-10-14 11:23:34 +00:00
fyrchik dismissed fyrchik's review 2024-10-14 11:23:39 +00:00
achuprov force-pushed feat/multiClient_node_address from 682e04f780 to ef2808c687 2024-10-14 13:08:00 +00:00 Compare
achuprov dismissed dstepanov-yadro's review 2024-10-14 13:08:00 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed a-savchuk's review 2024-10-14 13:08:00 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fyrchik approved these changes 2024-10-15 14:05:19 +00:00
fyrchik merged commit 90f3669399 into master 2024-10-15 14:05:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1428
No description provided.
Delete branch "achuprov/frostfs-node:feat/multiClient_node_address"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?