TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 107 Pull requests 3 Projects Releases 2 Activity Actions

Remove "could not"/"can't"/"failed to" from error messages #1568

Merged
fyrchik merged 2 commits from fyrchik/frostfs-node:fix-errors into master 2024-12-18 15:52:27 +00:00
Conversation 2 Commits 2 Files changed 39 +128 -128
fyrchik commented 2024-12-18 06:41:46 +00:00
Owner
Copy link
No description provided.
fyrchik added 2 commits 2024-12-18 06:41:47 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
pilorama: Replace "containerID" with "container ID" in the error message
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 3m5s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m37s
Details
Tests and linters / gopls check (pull_request) Successful in 6m9s
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m5s
Details
DCO action / DCO (pull_request) Failing after 10m24s
Details
Vulncheck / Vulncheck (pull_request) Successful in 11m46s
Details
Build / Build Components (pull_request) Successful in 12m55s
Details
Tests and linters / Staticcheck (pull_request) Successful in 12m51s
Details
Tests and linters / Tests (pull_request) Successful in 13m11s
Details
Tests and linters / Lint (pull_request) Successful in 13m38s
Details
e5cc739886 
It is "container ID" in every other place.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-12-18 06:41:47 +00:00
fyrchik requested review from storage-core-developers 2024-12-18 06:41:47 +00:00
fyrchik force-pushed fix-errors from e5cc739886 to 09b486fe33 2024-12-18 06:42:45 +00:00 Compare
fyrchik force-pushed fix-errors from 09b486fe33 to 0bee029e55 2024-12-18 06:47:44 +00:00 Compare
aarifullin commented 2024-12-18 07:52:38 +00:00
Member
Copy link

As we're enhancing error messages, could you, please, also truncate error word from "... error: %w errors in non-cmd packages?

As we're enhancing error messages, could you, please, also truncate `error` word from `"... error: %w` errors in non-`cmd` packages?
elebedeva approved these changes 2024-12-18 11:04:24 +00:00
fyrchik commented 2024-12-18 12:17:21 +00:00
Author
Owner
Copy link

@aarifullin not in this PR, it is not the last

@aarifullin not in this PR, it is not the last
achuprov approved these changes 2024-12-18 12:42:18 +00:00
acid-ant approved these changes 2024-12-18 13:33:42 +00:00
fyrchik merged commit 226dd25dd0 into master 2024-12-18 15:52:27 +00:00
fyrchik deleted branch fix-errors 2024-12-18 15:52:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
elebedeva
achuprov
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1568
No description provided.
Delete branch "fyrchik/frostfs-node:fix-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?