TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 109 Pull requests 2 Projects Releases 1 Activity Actions

node: Simplify bootstrapWithState() #1573

Open
fyrchik wants to merge 1 commit from fyrchik/frostfs-node:fix-bootstrap into master
pull from: fyrchik/frostfs-node:fix-bootstrap
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +4 -8
fyrchik commented 2024-12-19 13:08:54 +00:00
Owner
Copy link

After #1382 we have no need to use lambdas.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

After #1382 we have no need to use lambdas. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2024-12-19 13:08:55 +00:00
node: Simplify bootstrapWithState()
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 3m51s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m31s
Details
Tests and linters / gopls check (pull_request) Successful in 5m48s
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m46s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 11m22s
Details
DCO action / DCO (pull_request) Failing after 11m55s
Details
Build / Build Components (pull_request) Successful in 13m50s
Details
Tests and linters / Staticcheck (pull_request) Successful in 14m5s
Details
Tests and linters / Tests (pull_request) Successful in 14m7s
Details
Tests and linters / Lint (pull_request) Successful in 15m7s
Details
65647bea5b 
After #1382 we have no need to use lambdas.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-12-19 13:08:55 +00:00
fyrchik requested review from storage-core-developers 2024-12-19 13:08:55 +00:00
fyrchik force-pushed fix-bootstrap from 65647bea5b to 9e6341849b 2024-12-19 13:09:11 +00:00 Compare
elebedeva approved these changes 2024-12-19 13:56:00 +00:00
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 4m29s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m8s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m24s
Required
Details
DCO action / DCO (pull_request) Successful in 11m41s
Required
Details
Build / Build Components (pull_request) Successful in 13m35s
Required
Details
Tests and linters / Tests (pull_request) Successful in 13m35s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 13m51s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 14m35s
Required
Details
Tests and linters / Lint (pull_request) Successful in 14m54s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m31s
Required
Details
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-bootstrap:fyrchik-fix-bootstrap
git checkout fyrchik-fix-bootstrap
Sign in to join this conversation.
Reviewers
No reviewers
elebedeva
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1573
No description provided.
Delete branch "fyrchik/frostfs-node:fix-bootstrap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?