TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

WIP: metrics: Rename app_info metric #1576

Draft
elebedeva wants to merge 1 commit from elebedeva/frostfs-node:fix/rename-app_info-metric into master
pull from: elebedeva/frostfs-node:fix/rename-app_info-metric
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +1 -1
elebedeva commented 2024-12-20 11:09:05 +00:00
Member
Copy link

Close #1531

frostfs-app-info

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1531 ![frostfs-app-info](/attachments/73918ae7-2643-431d-ba3f-faee688169e4) Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva added the
frostfs-node
observability
 labels 2024-12-20 11:09:05 +00:00
elebedeva added 1 commit 2024-12-20 11:09:05 +00:00
[#1531] metrics: Rename app_info metric
All checks were successful
Vulncheck / Vulncheck (pull_request) Successful in 4m36s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m45s
Details
Tests and linters / gopls check (pull_request) Successful in 5m5s
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m9s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 10m27s
Details
DCO action / DCO (pull_request) Successful in 10m43s
Details
Tests and linters / Staticcheck (pull_request) Successful in 12m15s
Details
Build / Build Components (pull_request) Successful in 12m36s
Details
Tests and linters / Lint (pull_request) Successful in 12m40s
Details
Tests and linters / Tests (pull_request) Successful in 11m21s
Details
7dfe1ee9c1 
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva requested review from storage-core-committers 2024-12-20 11:09:05 +00:00
elebedeva requested review from storage-core-developers 2024-12-20 11:09:05 +00:00
a-savchuk approved these changes 2024-12-20 11:29:15 +00:00
achuprov approved these changes 2024-12-20 11:29:37 +00:00
fyrchik requested changes 2024-12-20 11:36:00 +00:00
internal/metrics/application.go
@ -13,3 +13,3 @@
appInfo := &ApplicationInfo{
versionValue: metrics.NewGaugeVec(prometheus.GaugeOpts{
Name: "app_info",
Name: "frostfs_node_app_info",
fyrchik commented 2024-12-20 11:35:59 +00:00
Owner
Copy link

Please, look at the other metrics.
We use Namespace field for this.

Please, look at the other metrics. We use `Namespace` field for this.
elebedeva changed title from metrics: Rename app_info metric to WIP: metrics: Rename app_info metric 2024-12-20 18:46:30 +00:00
All checks were successful
Vulncheck / Vulncheck (pull_request) Successful in 4m36s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m45s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 5m5s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m9s
Required
Details
Tests and linters / Run gofumpt (pull_request) Successful in 10m27s
Required
Details
DCO action / DCO (pull_request) Successful in 10m43s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 12m15s
Required
Details
Build / Build Components (pull_request) Successful in 12m36s
Required
Details
Tests and linters / Lint (pull_request) Successful in 12m40s
Required
Details
Tests and linters / Tests (pull_request) Successful in 11m21s
Required
Details
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/rename-app_info-metric:elebedeva-fix/rename-app_info-metric
git checkout elebedeva-fix/rename-app_info-metric
Sign in to join this conversation.
Reviewers
No reviewers
a-savchuk
achuprov
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1576
No description provided.
Delete branch "elebedeva/frostfs-node:fix/rename-app_info-metric"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?