Look for X-Headers within metaheader origin before APE check #1597

aarifullin · 2025-01-10T13:34:45Z

aarifullin commented

2025-01-10 13:34:45 +00:00

X-Headers can be found in origin field of MetaHeader if the request has been forwarded from non-container node.

When a request is forwarded to container node, metaheader is filled like that:

f.OnceResign.Do(func() {
		// compose meta header of the local server
		metaHdr := new(session.RequestMetaHeader)
		metaHdr.SetTTL(f.Request.GetMetaHeader().GetTTL() - 1)
		// TODO: #1165 think how to set the other fields
		metaHdr.SetOrigin(f.Request.GetMetaHeader())
		writeCurrentVersion(metaHdr)
		f.Request.SetMetaHeader(metaHdr)
		err = signature.SignServiceMessage(f.Key, f.Request)
	})

So, we expect x-headers may be found within origin (see also neo-node#1165)

Close #1243

* X-Headers can be found in `origin` field of `MetaHeader` if the request has been forwarded from non-container node. When a request is forwarded to container node, metaheader is filled like [that](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/services/object/get/v2/get_forwarder.go#L45-L54): ```go f.OnceResign.Do(func() { // compose meta header of the local server metaHdr := new(session.RequestMetaHeader) metaHdr.SetTTL(f.Request.GetMetaHeader().GetTTL() - 1) // TODO: #1165 think how to set the other fields metaHdr.SetOrigin(f.Request.GetMetaHeader()) writeCurrentVersion(metaHdr) f.Request.SetMetaHeader(metaHdr) err = signature.SignServiceMessage(f.Key, f.Request) }) ``` So, we expect x-headers may be found within `origin` (see also [neo-node#1165](https://github.com/nspcc-dev/neofs-node/issues/1165#issuecomment-1034723865)) Close #1243

aarifullin added the

bug

label 2025-01-10 13:34:45 +00:00

requested reviews from storage-core-committers, storage-core-developers

2025-01-10 13:34:46 +00:00

acid-ant approved these changes 2025-01-10 14:20:43 +00:00

Dismissed

achuprov approved these changes 2025-01-13 06:36:19 +00:00

Dismissed

fyrchik approved these changes 2025-01-13 06:37:26 +00:00

Dismissed

pkg/services/object/ape/service.go Outdated

					
				@ -479,0 +484,4 @@

				// getXHeaders retrieves x-headers from a request. If the request is being forwarded, then

				// x-headers may be found within `origin` field of meta header.

				func getXHeaders(mh metaHeaderProvider) (res []session.XHeader) {

fyrchik commented

2025-01-13 06:37:24 +00:00

Why have you decided to introduce an interface and use *Provider argument instead of getXHeaders(*session.RequestMetaHeader) []session.XHeader?

Why have you decided to introduce an interface and use `*Provider` argument instead of `getXHeaders(*session.RequestMetaHeader) []session.XHeader`?

aarifullin commented

2025-01-13 09:46:48 +00:00

The method is no longer actual as I used the approach suggested by @dstepanov-yadro

dstepanov-yadro reviewed 2025-01-13 06:43:29 +00:00

pkg/services/object/ape/service.go Outdated

					
				@ -479,0 +486,4 @@

				// x-headers may be found within `origin` field of meta header.

				func getXHeaders(mh metaHeaderProvider) (res []session.XHeader) {

					res = mh.GetMetaHeader().GetXHeaders()

					if len(res) == 0 {

dstepanov-yadro commented

2025-01-13 06:43:29 +00:00

See

meta := req.GetMetaHeader()

I think it should be the same.

See https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/a2485637bb91fcf976ce21cfa09af95f12c27c94/pkg/services/container/executor.go#L55 I think it should be the same.

dstepanov-yadro commented

2025-01-13 08:32:07 +00:00

The nesting can be more than 2 (theoretically).

aarifullin commented

2025-01-13 09:45:25 +00:00

It's very-very good point. Fixed!

aarifullin commented

2025-01-13 09:47:27 +00:00