Use slices.Clone()/bytes.Clone() where possible #1606

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:slices-clone into master 2025-01-17 12:15:18 +00:00
Owner

gopatch:

@@
var from, to expression
@@
+import "bytes"
-to := make([]byte, len(from))
-copy(to, from)
+to := bytes.Clone(from)

@@
var from, to expression
@@
+import "bytes"
-to = make([]byte, len(from))
-copy(to, from)
+to = bytes.Clone(from)

@@
var from, to, typ expression
@@
+import "slices"
-to := make([]typ, len(from))
-copy(to, from)
+to := slices.Clone(from)

@@
var from, to, typ expression
@@
+import "slices"
-to = make([]typ, len(from))
-copy(to, from)
+to = slices.Clone(from)

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

gopatch: ``` @@ var from, to expression @@ +import "bytes" -to := make([]byte, len(from)) -copy(to, from) +to := bytes.Clone(from) @@ var from, to expression @@ +import "bytes" -to = make([]byte, len(from)) -copy(to, from) +to = bytes.Clone(from) @@ var from, to, typ expression @@ +import "slices" -to := make([]typ, len(from)) -copy(to, from) +to := slices.Clone(from) @@ var from, to, typ expression @@ +import "slices" -to = make([]typ, len(from)) -copy(to, from) +to = slices.Clone(from) ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added the
refactoring
go
internal
labels 2025-01-17 10:52:37 +00:00
requested reviews from storage-core-committers, storage-core-developers 2025-01-17 10:52:38 +00:00
fyrchik force-pushed slices-clone from eaae40ed61 to c98357606b 2025-01-17 11:50:18 +00:00 Compare
a-savchuk approved these changes 2025-01-17 12:02:38 +00:00
dstepanov-yadro approved these changes 2025-01-17 12:03:31 +00:00
fyrchik merged commit c98357606b into master 2025-01-17 12:15:18 +00:00
fyrchik deleted branch slices-clone 2025-01-17 12:15:19 +00:00
fyrchik added this to the v0.45.0 milestone 2025-01-17 12:32:40 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1606
No description provided.