TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 11 Projects Releases 2 Activity Actions

WIP: innerring: Relax container homomorphic hashing check #1628

Draft
fyrchik wants to merge 1 commit from fyrchik/frostfs-node:fix-homorphic-check into master
pull from: fyrchik/frostfs-node:fix-homorphic-check
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +1 -1
fyrchik commented 2025-01-30 13:29:55 +00:00
Owner
Copy link

TBD: e2e testing

Our initial desire was to prohibit using homomorphic hashing on the
network level because of the resource consumption. However, the ability
to use it, doesn't mean that we must. So only fail validation if
container wants to have homomorphic hashing, but the network prohibits
it.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

TBD: e2e testing Our initial desire was to prohibit using homomorphic hashing on the network level because of the resource consumption. However, the ability to use it, doesn't mean that we must. So only fail validation if container wants to have homomorphic hashing, but the network prohibits it. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2025-01-30 13:29:55 +00:00
innerring: Relax container homomorphic hashing check
Some checks failed
DCO action / DCO (pull_request) Failing after 36s
Details
Vulncheck / Vulncheck (pull_request) Successful in 53s
Details
Build / Build Components (pull_request) Successful in 1m23s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m25s
Details
Tests and linters / gopls check (pull_request) Successful in 2m35s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m16s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m33s
Details
Tests and linters / Lint (pull_request) Successful in 4m46s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m55s
Details
Tests and linters / Tests (pull_request) Successful in 5m24s
Details
b8659dfd53 
Our initial desire was to prohibit using homomorphic hashing on the
network level because of the resource consumption. However, the ability
to use it, doesn't mean that we must. So only fail validation if
container wants to have homomorphic hashing, but the network prohibits
it.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-01-30 13:29:55 +00:00
fyrchik changed title from innerring: Relax container homomorphic hashing check to WIP: innerring: Relax container homomorphic hashing check 2025-01-30 13:30:10 +00:00
Some checks failed
DCO action / DCO (pull_request) Failing after 36s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 53s
Required
Details
Build / Build Components (pull_request) Successful in 1m23s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m25s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 2m35s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m16s
Required
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m33s
Required
Details
Tests and linters / Lint (pull_request) Successful in 4m46s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m55s
Required
Details
Tests and linters / Tests (pull_request) Successful in 5m24s
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-homorphic-check:fyrchik-fix-homorphic-check
git checkout fyrchik-fix-homorphic-check
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1628
No description provided.
Delete branch "fyrchik/frostfs-node:fix-homorphic-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?