TrueCloudLab/frostfs-node

Fork 28

Make listing chains with generated wallet #1638

Closed

aarifullin wants to merge 2 commits from aarifullin/frostfs-node:fix/apemngr_list_chain into master

aarifullin commented

2025-02-07 09:35:55 +00:00

Member

apemanager's method ListChains no longer validates request sender
frostfs-cli ape-manager list can be run with -g option

Close #1389

* `apemanager`'s method `ListChains` no longer validates request sender * `frostfs-cli ape-manager list` can be run with `-g` option Close #1389

aarifullin added 2 commits 2025-02-07 09:35:56 +00:00

[#1389 ] apemanager: Make list not validate sender key 44913898ef

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

[#1389 ] cli: Make ape-manager list performed with generated wallet

DCO action / DCO (pull_request) Successful in 41s

Details

Build / Build Components (pull_request) Successful in 1m31s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 1m32s

Details

Tests and linters / gopls check (pull_request) Successful in 2m25s

Details

Tests and linters / Run gofumpt (pull_request) Successful in 3m15s

Details

Tests and linters / Tests with -race (pull_request) Successful in 4m14s

Details

Tests and linters / Staticcheck (pull_request) Successful in 4m16s

Details

Tests and linters / Tests (pull_request) Successful in 4m35s

Details

Tests and linters / Lint (pull_request) Successful in 5m1s

Details

Vulncheck / Vulncheck (pull_request) Failing after 1m4s

Details

12955be08b

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

requested reviews from storage-core-committers, storage-core-developers

2025-02-07 09:35:56 +00:00

fyrchik approved these changes 2025-02-07 09:44:02 +00:00

fyrchik commented

2025-02-07 10:03:22 +00:00

Owner

On a second thought, it is not so simple.
Private access rules may be a feature.
Like not anyone can list containers in the namespace.

what do you think @alexvanin @realloc ?

On a second thought, it is not so simple. Private access rules may be a feature. Like not anyone can list containers in the namespace. what do you think @alexvanin @realloc ?

aarifullin commented

2025-02-07 11:16:23 +00:00

Author

Member

@fyrchik wrote in #1638 (comment):

Private access rules may be a feature.

I suppose such way for listing doesn't violate anything. Listing chains ignore signature checks. So, every target can be listed by raw listing with

neo-go contract testinvokefunction -r http://127.0.0.1:20332 0x3d30525ce97531926922cf22355f25cd8b85966e listChainsByPrefix "n" "" "ingress"

@fyrchik wrote in https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1638#issuecomment-66814: > Private access rules may be a feature. I suppose such way for listing doesn't violate anything. Listing chains ignore signature checks. So, every target can be listed by _raw_ listing with ```bash neo-go contract testinvokefunction -r http://127.0.0.1:20332 0x3d30525ce97531926922cf22355f25cd8b85966e listChainsByPrefix "n" "" "ingress" ```

acid-ant approved these changes 2025-02-07 11:29:21 +00:00

fyrchik commented

2025-02-07 11:56:43 +00:00

Owner

So, every target can be listed by raw

That is different, blockchain API is private, storage API is public.

>So, every target can be listed by raw That is different, blockchain API is private, storage API is public.

elebedeva approved these changes 2025-02-07 12:40:09 +00:00

aarifullin commented

2025-02-17 07:28:36 +00:00

Author

Member

This PR won't be merged because it breaks privacy giving the free access to list container APE rules and an owner isn't able to restrict this action (if we consider a public network).

As I've said above, the rules can be listed with neo-go contract testinvokefunction:

#1638 (comment)

This PR won't be merged because it breaks privacy giving the free access to list container APE rules and an owner isn't able to restrict this action (if we consider a public network). As I've said above, the rules can be listed with `neo-go contract testinvokefunction`: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1638#issuecomment-66839

aarifullin closed this pull request

2025-02-17 07:28:38 +00:00

aarifullin referenced this pull request

2025-02-17 07:29:22 +00:00

ape-manager service should allow list APE chains with node wallet #1389