TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 17 Projects Releases 2 Activity Actions

Wrap some errors with InvalidArgument status in apemanager service #1651

Open
aarifullin wants to merge 1 commit from aarifullin/frostfs-node:feat/improve_apemngr_errors into master
pull from: aarifullin/frostfs-node:feat/improve_apemngr_errors
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 2 +18 -7
aarifullin commented 2025-02-20 14:51:38 +00:00
Member
Copy link

ErrAPEManagerInvalidArgument has been introduced for ape-manager service

`ErrAPEManagerInvalidArgument` has been introduced for ape-manager service
aarifullin added 1 commit 2025-02-20 14:51:39 +00:00
[#xx] apemanager: Wrap some errors with InvalidArgument status
Some checks failed
DCO action / DCO (pull_request) Failing after 37s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 51s
Details
Vulncheck / Vulncheck (pull_request) Failing after 1m8s
Details
Build / Build Components (pull_request) Successful in 2m1s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m22s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m48s
Details
Tests and linters / Tests (pull_request) Successful in 2m29s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m18s
Details
Tests and linters / gopls check (pull_request) Successful in 3m25s
Details
Tests and linters / Lint (pull_request) Successful in 3m49s
Details
aea6f53edf 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-02-20 14:51:39 +00:00
aarifullin force-pushed feat/improve_apemngr_errors from aea6f53edf to 1884ba4ce8 2025-02-20 14:52:17 +00:00 Compare
achuprov approved these changes 2025-02-20 15:22:43 +00:00
dstepanov-yadro reviewed 2025-02-21 06:40:36 +00:00
pkg/services/apemanager/errors/errors.go
@ -10,2 +10,4 @@
return err
}
func ErrAPEManagerInvalidArgument(msg string) error {
dstepanov-yadro commented 2025-02-21 06:40:36 +00:00
Member
Copy link

Please write down the motivation for this change. In particular, I am interested in using status.Error(codes.InvalidArgument...) vs apemanager_errors.ErrAPEManagerInvalidArgument

Please write down the motivation for this change. In particular, I am interested in using `status.Error(codes.InvalidArgument...)` vs `apemanager_errors.ErrAPEManagerInvalidArgument`
aarifullin commented 2025-02-21 11:21:27 +00:00
Author
Member
Copy link

status.Error(codes.InvalidArgument...) - probably, you're talking about the status from grpc-package (used in control services).
ErrAPEManagerInvalidArgument wraps into frostfs-api status

`status.Error(codes.InvalidArgument...)` - probably, you're talking about the status from `grpc`-package (used in control services). `ErrAPEManagerInvalidArgument` wraps into frostfs-api status
dstepanov-yadro commented 2025-02-21 11:46:22 +00:00
Member
Copy link

Got it, thanks

Got it, thanks
dstepanov-yadro marked this conversation as resolved
dstepanov-yadro approved these changes 2025-02-21 11:46:29 +00:00
acid-ant approved these changes 2025-02-21 13:21:29 +00:00
elebedeva approved these changes 2025-02-24 07:43:49 +00:00
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 46s
Required
Details
DCO action / DCO (pull_request) Successful in 1m1s
Required
Details
Vulncheck / Vulncheck (pull_request) Failing after 1m22s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m14s
Required
Details
Build / Build Components (pull_request) Successful in 2m18s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m43s
Required
Details
Tests and linters / Tests (pull_request) Successful in 2m59s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 3m25s
Required
Details
Tests and linters / Lint (pull_request) Successful in 3m43s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m0s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feat/improve_apemngr_errors:aarifullin-feat/improve_apemngr_errors
git checkout aarifullin-feat/improve_apemngr_errors
Sign in to join this conversation.
Reviewers
No reviewers
achuprov
dstepanov-yadro
acid-ant
elebedeva
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1651
No description provided.
Delete branch "aarifullin/frostfs-node:feat/improve_apemngr_errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?