TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 9 Projects Releases 2 Activity Actions

adm: Make 'morph-init' idempotent #1654

Merged
fyrchik merged 2 commits from achuprov/frostfs-node:bugfix/make_init_ideo into master 2025-02-27 11:57:46 +00:00
Conversation 0 Commits 2 Files changed 1 +20 -9
achuprov commented 2025-02-24 09:28:53 +00:00
Member
Copy link

Ref: TrueCloudLab/frostfs-dev-env#94
The value of the alphabet balance is unstable. The balance of consensus account appears to be a more reliable indicator.
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Ref: https://git.frostfs.info/TrueCloudLab/frostfs-dev-env/issues/94 The value of the alphabet balance is unstable. The balance of consensus account appears to be a more reliable indicator. Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2025-02-24 09:28:54 +00:00
[#1654] adm: Make 'morph-init' idempotent
All checks were successful
DCO action / DCO (pull_request) Successful in 34s
Details
Vulncheck / Vulncheck (pull_request) Successful in 53s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m24s
Details
Build / Build Components (pull_request) Successful in 1m28s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m58s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m11s
Details
Tests and linters / Tests (pull_request) Successful in 2m26s
Details
Tests and linters / Lint (pull_request) Successful in 2m52s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m2s
Details
Tests and linters / gopls check (pull_request) Successful in 3m39s
Details
1c43fcdda9 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-02-24 09:28:54 +00:00
fyrchik reviewed 2025-02-24 09:35:18 +00:00
cmd/frostfs-adm/internal/modules/morph/initialize/initialize_transfer.go Outdated
@ -28,2 +28,4 @@
// initialProxyGASAmount represents the amount of GAS given to a proxy contract.
initialProxyGASAmount = 50_000 * native.GASFactor
// InitialGASSupply contains value from https://github.com/nspcc-dev/neo-go/blob/0d8c751e50951ad84cec8b89cf6ea1a9e0f4f878/config/protocol.mainnet.yml#L4
InitialGASSupply = 52000000 * native.GASFactor
fyrchik commented 2025-02-24 09:35:18 +00:00
Owner
Copy link

There is also gasInitialTotalSupply, what is the difference?
Also, this value may differ between networks, I think getversion RPC should contain the actual value.

There is also `gasInitialTotalSupply`, what is the difference? Also, this value may differ between networks, I think `getversion` RPC should contain the actual value.
achuprov commented 2025-02-24 11:30:29 +00:00
Author
Member
Copy link

Also, this value may differ between networks, I think getversion RPC should contain the actual value.

You are right. Fixed.

There is also gasInitialTotalSupply, what is the difference?

I believe it's old value of initialGasDistribution. Add commit "get gasInitialTotalSupply from the network". link1 and link2

> Also, this value may differ between networks, I think getversion RPC should contain the actual value. You are right. Fixed. > There is also gasInitialTotalSupply, what is the difference? I believe it's old value of `initialGasDistribution`. Add commit "get `gasInitialTotalSupply` from the network". [link1](https://github.com/neo-project/neo/pull/2544) and [link2](https://github.com/nspcc-dev/neofs-node/pull/707)
achuprov force-pushed bugfix/make_init_ideo from 1c43fcdda9 to e8cb6b30c9 2025-02-24 09:47:30 +00:00 Compare
achuprov added 1 commit 2025-02-24 10:22:46 +00:00
[#1654] adm: Get 'gasInitialTotalSupply' from network
All checks were successful
DCO action / DCO (pull_request) Successful in 42s
Details
Vulncheck / Vulncheck (pull_request) Successful in 50s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m24s
Details
Build / Build Components (pull_request) Successful in 1m39s
Details
Tests and linters / Tests (pull_request) Successful in 3m9s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 3m10s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m23s
Details
Tests and linters / Lint (pull_request) Successful in 3m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m26s
Details
Tests and linters / gopls check (pull_request) Successful in 3m56s
Details
8e57d74e38 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
fyrchik approved these changes 2025-02-25 09:11:41 +00:00
aarifullin approved these changes 2025-02-27 11:30:49 +00:00
fyrchik merged commit 2ff032db90 into master 2025-02-27 11:57:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1654
No description provided.
Delete branch "achuprov/frostfs-node:bugfix/make_init_ideo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?