node: Validate RPC limiter configuration #1658
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1658
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "a-savchuk/frostfs-node:rpc-limiter-validation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Validate that configured limits match the methods registered earlier. Tested on service start and reload for both
frost.fs
andneo.fs.v2
package names.9e81952048
to799ae3ce75
WIP: node: Validate RPC limiter configurationto node: Validate RPC limiter configuration@ -234,0 +258,4 @@
for _, limit := range limits {
for _, method := range limit.Keys {
if _, ok := availableMethods[method]; !ok {
return fmt.Errorf("set limit on unknown method %q", method)
on unknown
->on an unknown
Fixed
799ae3ce75
toc660271039
New commits pushed, approval review dismissed automatically according to repository settings
@ -234,0 +253,4 @@
return nil
}
func validateRPCLimits(c *cfg, limits []limiting.KeyLimit) error {
A controversial point.
What if I want to disable tree or control service? In this case, I definitely have to edit the configuration file for the limits.
Does "disable" mean setting limit to 0. What's the problem then? Can you please give more detail?
As I remember, we also agreed that we don't apply limiting for control service
Disabling tree service is a fine point.
But in this case editing configuration is probably warranted?
It is not an operation one would do frequently.