TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 9 Projects Releases 2 Activity Actions

cli: Clarify --rpc-endpoint values #1661

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:cli-rpc-endpoint into master 2025-03-04 07:59:23 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
fyrchik commented 2025-03-04 07:18:36 +00:00
Owner
Copy link

multiaddr is not something an average user knows. Personally, I have
never used it in CLI. On the other hand, we need to connect with TLS quite often,
so it needs to be mentioned in help.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

`multiaddr` is not something an average user knows. Personally, I have never used it in CLI. On the other hand, we need to connect with TLS quite often, so it needs to be mentioned in help. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2025-03-04 07:18:37 +00:00
cli: Clarify --rpc-endpoint values
Some checks failed
DCO action / DCO (pull_request) Failing after 33s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m1s
Details
Build / Build Components (pull_request) Successful in 1m29s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m28s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m53s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m23s
Details
Tests and linters / Lint (pull_request) Successful in 3m29s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m32s
Details
Tests and linters / Tests (pull_request) Successful in 3m40s
Details
Tests and linters / gopls check (pull_request) Successful in 4m15s
Details
38a99786a4 
`multiaddr` is not something an average user knows. Personally, I have
never used it in CLI. On the other hand, we need to connect with TLS quite often,
so it needs to be mentioned in help.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-03-04 07:18:37 +00:00
fyrchik force-pushed cli-rpc-endpoint from 38a99786a4 to 5ba0e2918e 2025-03-04 07:19:59 +00:00 Compare
a-savchuk approved these changes 2025-03-04 07:21:50 +00:00
fyrchik added this to the v0.45.0 milestone 2025-03-04 07:22:14 +00:00
acid-ant approved these changes 2025-03-04 07:23:13 +00:00
achuprov approved these changes 2025-03-04 07:36:06 +00:00
fyrchik merged commit 5ba0e2918e into master 2025-03-04 07:59:23 +00:00
fyrchik deleted branch cli-rpc-endpoint 2025-03-04 07:59:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a-savchuk
acid-ant
achuprov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.45.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1661
No description provided.
Delete branch "fyrchik/frostfs-node:cli-rpc-endpoint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?