TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 7 Projects Releases 2 Activity Actions

Fix CloseAndRecv for patch streamer #1662

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/patch/close_panic into master 2025-03-05 14:41:48 +00:00
Conversation 0 Commits 1 Files changed 1 +3
aarifullin commented 2025-03-05 14:14:17 +00:00
Member
Copy link
  • A client may open stream to server, not send anything and close the open stream immediatly. This shouldn't cause a panic;
  • Return the error if s.patcher is uninitialized. Uninitialized patcher cannot be closed, this causes a panic.
* A client may open stream to server, not send anything and close the open stream immediatly. This shouldn't cause a panic; * Return the error if `s.patcher` is uninitialized. Uninitialized patcher cannot be closed, this causes a panic.
aarifullin added the
bug
 label 2025-03-05 14:14:17 +00:00
aarifullin added 1 commit 2025-03-05 14:14:17 +00:00
[#xx] object: Fix CloseAndRecv for patch streamer
Some checks failed
DCO action / DCO (pull_request) Failing after 27s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m0s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m22s
Details
Build / Build Components (pull_request) Successful in 1m29s
Details
Tests and linters / Lint (pull_request) Successful in 3m15s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m10s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m58s
Details
Tests and linters / Tests (pull_request) Successful in 3m2s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m14s
Details
Tests and linters / gopls check (pull_request) Successful in 4m22s
Details
4951e77bfd 
* A client may open stream to server, not send anything and close
  the open stream immediatly. This shouldn't cause a panic;
* Return the error if `s.patcher` is uninitialized. Uninitialized
  patcher cannot be closed, this causes a panic.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-03-05 14:14:17 +00:00
aarifullin force-pushed fix/patch/close_panic from 4951e77bfd to 4c8f9580a1 2025-03-05 14:17:25 +00:00 Compare
dstepanov-yadro approved these changes 2025-03-05 14:21:33 +00:00
fyrchik approved these changes 2025-03-05 14:41:32 +00:00
fyrchik merged commit 4c8f9580a1 into master 2025-03-05 14:41:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1662
No description provided.
Delete branch "aarifullin/frostfs-node:fix/patch/close_panic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?