TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 9 Projects Releases 2 Activity Actions

writecache: Use object size to check free space #1668

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/writecache_put_space_estimation into master 2025-03-11 08:12:07 +00:00
Conversation 0 Commits 1 Files changed 2 +10 -5
dstepanov-yadro commented 2025-03-10 14:52:41 +00:00
Member
Copy link

Before this PR maxObjectSize was used.

Before this PR `maxObjectSize` was used.
dstepanov-yadro added 1 commit 2025-03-10 14:52:41 +00:00
[#9999] writecache: Use object size to check free space
All checks were successful
DCO action / DCO (pull_request) Successful in 40s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m34s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m46s
Details
Build / Build Components (pull_request) Successful in 2m31s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m53s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m26s
Details
Tests and linters / Lint (pull_request) Successful in 3m31s
Details
Tests and linters / Tests (pull_request) Successful in 3m59s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m57s
Details
Tests and linters / gopls check (pull_request) Successful in 3m55s
Details
38663a3163 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-03-10 14:52:42 +00:00
dstepanov-yadro force-pushed fix/writecache_put_space_estimation from 38663a3163 to 8643e0abc5 2025-03-10 14:53:31 +00:00 Compare
acid-ant approved these changes 2025-03-10 15:54:51 +00:00
elebedeva approved these changes 2025-03-10 16:30:18 +00:00
fyrchik approved these changes 2025-03-11 07:41:02 +00:00
pkg/local_object_storage/writecache/put.go
@ -60,3 +61,3 @@
// putBig writes object to FSTree and pushes it to the flush workers queue.
func (c *cache) putBig(ctx context.Context, prm common.PutPrm) error {
if !c.hasEnoughSpaceFS() {
if prm.RawData == nil { // foolproof: RawData should be marshalled by shard.
fyrchik commented 2025-03-11 07:40:59 +00:00
Owner
Copy link

Even if it is not marshaled, that is not useless.
But could you please double-check that fstree also marshals only if RawData == nil?

Even if it is not marshaled, that is not useless. But could you please double-check that fstree also marshals only if `RawData == nil`?
dstepanov-yadro commented 2025-03-11 08:01:59 +00:00
Author
Member
Copy link

There is no such check in fstree, but it exists at the blobstor level.

There is no such check in `fstree`, but it exists at the `blobstor` level.
dstepanov-yadro commented 2025-03-11 08:03:05 +00:00
Author
Member
Copy link

I mean check than RawData != nil and marshal object otherwise.

I mean check than RawData != nil and marshal object otherwise.
dstepanov-yadro merged commit 8643e0abc5 into master 2025-03-11 08:12:07 +00:00
dstepanov-yadro deleted branch fix/writecache_put_space_estimation 2025-03-11 08:12:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
elebedeva
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1668
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/writecache_put_space_estimation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?