TrueCloudLab/frostfs-node

Fork 27

WIP: Reuse `acl/v2` middleware as a new middleware `context_enricher` #1670

Draft

aarifullin wants to merge 6 commits from aarifullin/frostfs-node:feat/1052_factorout_acl into master

aarifullin commented

2025-03-12 15:34:03 +00:00

Member

Nuke out the acl/eacl package. We don't use eACL mechanics anymore
Slightly refactor helper type like RequestInfo and MetaWithToken
acl/v2 middleware is moved to context_enricher: the middleware is responsible for enriching a request context with values that are retrieved only once, allowing these values to be used in subsequent middlewares (basically, APE)
Fix imports

Close #1052

* Nuke out the `acl/eacl` package. We don't use eACL mechanics anymore * Slightly refactor helper type like `RequestInfo` and `MetaWithToken` * `acl/v2` middleware is moved to `context_enricher`: the middleware is responsible for enriching a request context with values that are retrieved only once, allowing these values to be used in subsequent middlewares (basically, `APE`) * Fix imports Close #1052

aarifullin added the

refactoring

label 2025-03-12 15:34:03 +00:00

aarifullin added 6 commits 2025-03-12 15:34:03 +00:00

[#1052 ] object: Remove acl/eacl package 291d1bf17e

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

[#1052 ] object: Remove acl fields from RequstInfo in ACL middleware f25c820a89

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

[#1052 ] object: Remove unused fields from RequestInfo and MetaWithToken afad78b44c

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

[#1052 ] object: Make ACL middleware not use acl operation 51f44c8f39

* Remove unused methods and unactual unit-test.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

[#1052 ] object: Rename acl/v2 package to context_enricher f029752e2e

* Fix import in `cmd/frostfs-node` as `acl/v2` no longer exists;
* Rename `createACLServiceV2` to `createContextEnricher`.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

[#1052 ] object: Fix explanatory comments for context_enricher

DCO action / DCO (pull_request) Successful in 39s

Details

Vulncheck / Vulncheck (pull_request) Successful in 1m5s

Details

Build / Build Components (pull_request) Successful in 1m24s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 1m26s

Details

Tests and linters / Run gofumpt (pull_request) Successful in 2m12s

Details

Tests and linters / Tests (pull_request) Successful in 2m28s

Details

Tests and linters / Staticcheck (pull_request) Successful in 2m36s

Details

Tests and linters / Lint (pull_request) Successful in 2m44s

Details

Tests and linters / gopls check (pull_request) Successful in 3m10s

Details

Tests and linters / Tests with -race (pull_request) Successful in 4m36s

Details

ea5ccc052d

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

requested reviews from storage-core-developers, storage-core-committers

2025-03-12 15:34:04 +00:00

fyrchik requested changes 2025-03-13 08:16:58 +00:00

fyrchik left a comment

Owner

Frankly, context_enricher complicates things.
We used passing via context as a hack to provide the same struct to multiple services, without recalculation.
But it introduces implicit logic, so now we could remove it.

There are also things like assertSessionRelation, so this context_enricher does more that its name implies.

Frankly, `context_enricher` complicates things. We used passing via context as a hack to provide the same struct to multiple services, without recalculation. But it introduces implicit logic, so now we could remove it. There are also things like `assertSessionRelation`, so this `context_enricher` does more that its name implies.

aarifullin changed title from ~~Reuse acl/v2 middleware as a new middleware context_enricher~~ to WIP: Reuse acl/v2 middleware as a new middleware context_enricher

2025-03-13 08:40:27 +00:00