WIP: Reuse acl/v2
middleware as a new middleware context_enricher
#1670
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1670
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "aarifullin/frostfs-node:feat/1052_factorout_acl"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
acl/eacl
package. We don't use eACL mechanics anymoreRequestInfo
andMetaWithToken
acl/v2
middleware is moved tocontext_enricher
: the middleware is responsible for enriching a request context with values that are retrieved only once, allowing these values to be used in subsequent middlewares (basically,APE
)Close #1052
acl/eacl
package 291d1bf17eRequstInfo
in ACL middleware f25c820a89RequestInfo
andMetaWithToken
afad78b44cacl/v2
package tocontext_enricher
f029752e2econtext_enricher
Frankly,
context_enricher
complicates things.We used passing via context as a hack to provide the same struct to multiple services, without recalculation.
But it introduces implicit logic, so now we could remove it.
There are also things like
assertSessionRelation
, so thiscontext_enricher
does more that its name implies.Reuseto WIP: Reuseacl/v2
middleware as a new middlewarecontext_enricher
acl/v2
middleware as a new middlewarecontext_enricher
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.