TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 9 Projects Releases 2 Activity Actions

writecache: Add QoS limiter usage #1677

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:feat/writecache_shard_limiter into master 2025-03-14 13:31:24 +00:00
Conversation 0 Commits 1 Files changed 5 +27 -1
dstepanov-yadro commented 2025-03-13 15:02:26 +00:00
Member
Copy link

Missed QoS for writecache .

Missed QoS for writecache .
dstepanov-yadro added 1 commit 2025-03-13 15:02:27 +00:00
[#9999] writecache: Add QoS limiter usage
All checks were successful
DCO action / DCO (pull_request) Successful in 27s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m7s
Details
Build / Build Components (pull_request) Successful in 1m30s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m33s
Details
Tests and linters / Lint (pull_request) Successful in 3m24s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 3m17s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m34s
Details
Tests and linters / Tests (pull_request) Successful in 3m36s
Details
Tests and linters / gopls check (pull_request) Successful in 4m10s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m29s
Details
60ccd588dd 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-03-13 15:02:27 +00:00
dstepanov-yadro force-pushed feat/writecache_shard_limiter from 60ccd588dd to 098e94dd15 2025-03-13 15:03:22 +00:00 Compare
acid-ant reviewed 2025-03-14 07:02:22 +00:00
pkg/local_object_storage/writecache/flush.go Outdated
@ -188,1 +204,4 @@
return err
}
res, err := c.blobstor.Put(ctx, prm)
release()
acid-ant commented 2025-03-14 07:02:22 +00:00
Member
Copy link

Why it is necessary to separately limit access to blobstor and meta? From wc point of view, it is one operation - flush.

Why it is necessary to separately limit access to `blobstor` and `meta`? From `wc` point of view, it is one operation - `flush`.
dstepanov-yadro commented 2025-03-14 08:45:40 +00:00
Author
Member
Copy link

Agree, fixed

Agree, fixed
acid-ant approved these changes 2025-03-14 07:03:15 +00:00
Dismissed
dstepanov-yadro force-pushed feat/writecache_shard_limiter from 098e94dd15 to 6a380b99c8 2025-03-14 08:26:27 +00:00 Compare
dstepanov-yadro dismissed acid-ant's review 2025-03-14 08:26:27 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro force-pushed feat/writecache_shard_limiter from 6a380b99c8 to d8cf9c5125 2025-03-14 08:45:13 +00:00 Compare
requested reviews from storage-core-committers, storage-core-developers 2025-03-14 08:46:00 +00:00
elebedeva approved these changes 2025-03-14 11:08:56 +00:00
acid-ant approved these changes 2025-03-14 11:21:35 +00:00
requested review from fyrchik 2025-03-14 13:07:26 +00:00
dstepanov-yadro force-pushed feat/writecache_shard_limiter from d8cf9c5125 to 07a660fbc4 2025-03-14 13:23:58 +00:00 Compare
fyrchik approved these changes 2025-03-14 13:31:19 +00:00
fyrchik merged commit 07a660fbc4 into master 2025-03-14 13:31:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
elebedeva
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1677
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/writecache_shard_limiter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?