TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 9 Projects Releases 2 Activity Actions

Fix frostfs-adm morph list-subjects & list-group-subjects #1678

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/list_subjects into master 2025-03-14 13:42:30 +00:00
Conversation 0 Commits 1 Files changed 1 +39 -13
dstepanov-yadro commented 2025-03-14 09:08:00 +00:00
Member
Copy link

include-names for list-subjects returns error invalid response subject struct because ListSubjects returns only subject addresses (see frostfs-contract).

Replace include-names with extended as now all subject info printed.

Output example:

frostfs-adm morph frostfsid list-subjects -c /home/dstepanov/src/tatlin-object-sber-tfstate/dkarmanov_proxmox/configuration/config.yaml --namespace "" --extended
Address: NLQ68W5RhEZjwmpufBKD3T1C9EkPNXN6EH
Primary key: dec68b6b6b04c6d19e4644f49d0b710e5c862ce3a902974702dfc4322e3ebc6f58ff1b8790b570e4d10b9f364cc5401d64130f4c8b1a4bbb9f2ad1fbb09a3168
Name: service1
Namespace: 
Additional keys:
- 2793f4fafbfd8dff089fb2f6816b1389e658dedb8f7ed16f82a01d5ef6c68e8a7867cb918c39c6acab0e66206e31c1e7112b95ca29b87ad91591c758ebce9321
KV:
- PasswordLastUsed: 1741931383
- Path: /
- CreateDate: 1741931383

Address: Nbcy1mcRbWThDRWDRwZhg6Hy3rUqjNzxH2
Primary key: 906ff5f6c3d2e35cddaae01b52942fd6d6d3bc8a781fe8a0c0a7f796eab5a4601a11fd879ff3b2974bb69de80fcb92f7a5cb252ca3f10868942ae532c2e30f95
Name: service
Namespace: 
Additional keys:
- 49893b3d7ad6f0329e06f862b3b9add213e76183203fff3836a0783ff143d383533b632ad44277cf7c8ec1842dd758439aba48bfc9efa244a33e5c433abf3e2b
- 4f8a90bedc77f5954dc739e62550d9a24fc36b6b2ded38eedad9660575c6d50ff9b4a9ead6609561a2eea1ea98b6972e88b8dc0a0fbe75a2beeb37569b5b3f72
- 81cf09aefe354f1b653ecb084facae35bae35910097253c7670d01c664f03bd67cddeee5adb609cd87cb4e82998f8ee773e9e0488a5df3279a9856a7a55a08a2
- 9e2042cb48ec1a7864554290be514d3d3f6bc5cd90d915d947f85f3955804f48fadc94ba89d22fe7bc89c05d5af42fa284b8d7c901f2fad72c15d0506a52f312
KV:
- CreateDate: 1741892805
- PasswordLastUsed: 1741892805
- Path: /
`include-names` for `list-subjects` returns error `invalid response subject struct` because `ListSubjects` returns only subject addresses (see frostfs-contract). Replace `include-names` with `extended` as now all subject info printed. Output example: ``` frostfs-adm morph frostfsid list-subjects -c /home/dstepanov/src/tatlin-object-sber-tfstate/dkarmanov_proxmox/configuration/config.yaml --namespace "" --extended Address: NLQ68W5RhEZjwmpufBKD3T1C9EkPNXN6EH Primary key: dec68b6b6b04c6d19e4644f49d0b710e5c862ce3a902974702dfc4322e3ebc6f58ff1b8790b570e4d10b9f364cc5401d64130f4c8b1a4bbb9f2ad1fbb09a3168 Name: service1 Namespace: Additional keys: - 2793f4fafbfd8dff089fb2f6816b1389e658dedb8f7ed16f82a01d5ef6c68e8a7867cb918c39c6acab0e66206e31c1e7112b95ca29b87ad91591c758ebce9321 KV: - PasswordLastUsed: 1741931383 - Path: / - CreateDate: 1741931383 Address: Nbcy1mcRbWThDRWDRwZhg6Hy3rUqjNzxH2 Primary key: 906ff5f6c3d2e35cddaae01b52942fd6d6d3bc8a781fe8a0c0a7f796eab5a4601a11fd879ff3b2974bb69de80fcb92f7a5cb252ca3f10868942ae532c2e30f95 Name: service Namespace: Additional keys: - 49893b3d7ad6f0329e06f862b3b9add213e76183203fff3836a0783ff143d383533b632ad44277cf7c8ec1842dd758439aba48bfc9efa244a33e5c433abf3e2b - 4f8a90bedc77f5954dc739e62550d9a24fc36b6b2ded38eedad9660575c6d50ff9b4a9ead6609561a2eea1ea98b6972e88b8dc0a0fbe75a2beeb37569b5b3f72 - 81cf09aefe354f1b653ecb084facae35bae35910097253c7670d01c664f03bd67cddeee5adb609cd87cb4e82998f8ee773e9e0488a5df3279a9856a7a55a08a2 - 9e2042cb48ec1a7864554290be514d3d3f6bc5cd90d915d947f85f3955804f48fadc94ba89d22fe7bc89c05d5af42fa284b8d7c901f2fad72c15d0506a52f312 KV: - CreateDate: 1741892805 - PasswordLastUsed: 1741892805 - Path: / ```
dstepanov-yadro added 1 commit 2025-03-14 09:08:00 +00:00
[#9999] adm: Fix frostfs-adm morph list-subjects & list-group-subjects
All checks were successful
DCO action / DCO (pull_request) Successful in 50s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m13s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m25s
Details
Build / Build Components (pull_request) Successful in 1m37s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 3m32s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m55s
Details
Tests and linters / Lint (pull_request) Successful in 4m0s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m13s
Details
Tests and linters / gopls check (pull_request) Successful in 4m32s
Details
Tests and linters / Tests (pull_request) Successful in 4m57s
Details
5fdb2ebc1d 
`include-names` for `list-subjects` returns error `invalid response subject struct`
because `ListSubjects` returns only subject addresses (see frostfs-contract).

Replace `include-names` with `extended` as now all subject info printed.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/list_subjects from 5fdb2ebc1d to 7f57516f63 2025-03-14 09:09:10 +00:00 Compare
dstepanov-yadro force-pushed fix/list_subjects from 7f57516f63 to 442ab5ec7b 2025-03-14 09:11:04 +00:00 Compare
dstepanov-yadro changed title from WIP: adm: Fix frostfs-adm morph list-subjects & list-group-subjects to Fix frostfs-adm morph list-subjects & list-group-subjects 2025-03-14 12:42:22 +00:00
requested reviews from storage-core-committers, storage-core-developers 2025-03-14 12:42:23 +00:00
achuprov approved these changes 2025-03-14 13:36:31 +00:00
fyrchik merged commit fde2649e60 into master 2025-03-14 13:42:30 +00:00
fyrchik approved these changes 2025-03-14 13:42:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
achuprov
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1678
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/list_subjects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?