TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 109 Pull requests 9 Projects Releases 2 Activity Actions

Speedup metabase.Select(), part 1 #1683

Merged
fyrchik merged 2 commits from fyrchik/frostfs-node:speedup-search-1 into master 2025-03-18 11:48:52 +00:00
Conversation 0 Commits 2 Files changed 2 +3 -1

2 commits

Author SHA1 Message Date
Evgenii Stratonikov
b362823558
[#1683] metabase: Check object status once in Select()
All checks were successful
DCO action / DCO (pull_request) Successful in 31s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m22s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m20s
Details
Build / Build Components (pull_request) Successful in 1m43s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 3m31s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m40s
Details
Tests and linters / Lint (pull_request) Successful in 4m0s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m14s
Details
Tests and linters / Tests (pull_request) Successful in 4m19s
Details
Tests and linters / gopls check (pull_request) Successful in 6m1s
Details 
objectStatus() is called twice for the same object:
First, in selectObject() to filter removed objects.
Then, again, in getObjectForSlowFilters() via db.get().
The second call will return the same result, so remove useless branch.

```
goos: linux
goarch: amd64
pkg: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/metabase
cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
                          │     old     │                status                │
                          │   sec/op    │    sec/op     vs base                │
Select/string_equal-8       5.022m ± 7%   3.968m ±  8%  -20.98% (p=0.000 n=10)
Select/string_not_equal-8   4.953m ± 9%   3.990m ± 10%  -19.44% (p=0.000 n=10)
Select/common_prefix-8      4.962m ± 8%   3.971m ±  9%  -19.98% (p=0.000 n=10)
Select/unknown-8            5.246m ± 9%   3.548m ±  5%  -32.37% (p=0.000 n=10)
geomean                     5.045m        3.865m        -23.39%

                          │     old      │                status                │
                          │     B/op     │     B/op      vs base                │
Select/string_equal-8       2.685Mi ± 0%   2.250Mi ± 0%  -16.20% (p=0.000 n=10)
Select/string_not_equal-8   2.685Mi ± 0%   2.250Mi ± 0%  -16.20% (p=0.000 n=10)
Select/common_prefix-8      2.685Mi ± 0%   2.250Mi ± 0%  -16.20% (p=0.000 n=10)
Select/unknown-8            2.677Mi ± 0%   2.243Mi ± 0%  -16.24% (p=0.000 n=10)
geomean                     2.683Mi        2.248Mi       -16.21%

                          │     old     │               status                │
                          │  allocs/op  │  allocs/op   vs base                │
Select/string_equal-8       69.03k ± 0%   56.02k ± 0%  -18.84% (p=0.000 n=10)
Select/string_not_equal-8   69.03k ± 0%   56.02k ± 0%  -18.84% (p=0.000 n=10)
Select/common_prefix-8      69.03k ± 0%   56.02k ± 0%  -18.84% (p=0.000 n=10)
Select/unknown-8            68.03k ± 0%   55.03k ± 0%  -19.11% (p=0.000 n=10)
geomean                     68.78k        55.77k       -18.90%
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2025-03-18 14:21:41 +03:00
Evgenii Stratonikov
bb89fd3c5c
[#1683] metabase/test: Report allocs in benchmarkSelect() 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2025-03-18 14:21:41 +03:00