TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 113 Pull requests 4 Projects Releases 2 Activity Actions

Add maintenance zombie commands -> v0.42.18 #1711

Open
dstepanov-yadro wants to merge 4 commits from dstepanov-yadro/frostfs-node:zombie_162 into support/v0.42
pull from: dstepanov-yadro/frostfs-node:zombie_162
merge into: TrueCloudLab:support/v0.42
Conversation 0 Commits 4 Files changed 12 +1044 -1
dstepanov-yadro commented 2025-04-09 08:30:41 +00:00
Member
Copy link
No description provided.
dstepanov-yadro added 2 commits 2025-04-09 08:30:41 +00:00 
Change-Id: I263d3e06d0bbb9ab395cf4ef313f77f7ea57ac2f
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] amd: Adopt zombie scan to EC objects
Some checks failed
DCO action / DCO (pull_request) Successful in 30s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m19s
Details
Build / Build Components (pull_request) Successful in 1m48s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m49s
Details
Tests and linters / Tests (pull_request) Successful in 1m59s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m13s
Details
Tests and linters / gopls check (pull_request) Failing after 2m20s
Details
Tests and linters / Lint (pull_request) Successful in 2m50s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m49s
Details
e7aa9d7dd6 
Change-Id: Ida3f339bb6e8343519933b60cdc4b544f7a02f1c
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-04-09 08:30:42 +00:00
dstepanov-yadro added 1 commit 2025-04-09 10:33:32 +00:00
[#9999] core: Extend object info string with EC header
Some checks failed
DCO action / DCO (pull_request) Successful in 27s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m11s
Details
Build / Build Components (pull_request) Successful in 2m4s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m6s
Details
Tests and linters / gopls check (pull_request) Failing after 2m23s
Details
Tests and linters / Lint (pull_request) Successful in 2m42s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m50s
Details
Tests and linters / Tests (pull_request) Successful in 3m8s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m13s
Details
dcd05a02e7 
Change-Id: I9a60ab654078ce3d7c1c287b3ec17bbedc2c1a7e
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
aarifullin reviewed 2025-04-09 13:29:10 +00:00
cmd/frostfs-adm/internal/modules/maintenance/zombie/scan.go Outdated
@ -0,0 +130,4 @@
objID := obj.Address.Object()
cnrID := obj.Address.Container()
local := true
aarifullin commented 2025-04-09 13:29:10 +00:00
Member
Copy link

Not a big deal, but

local := obj.ECInfo == nil
if !local {
  objID = obj.ECInfo.ParentID
}
Not a big deal, but ```go local := obj.ECInfo == nil if !local { objID = obj.ECInfo.ParentID } ```
fyrchik reviewed 2025-04-09 14:23:55 +00:00
cmd/frostfs-adm/internal/modules/maintenance/zombie/scan.go Outdated
@ -0,0 +133,4 @@
local := true
if obj.ECInfo != nil {
objID = obj.ECInfo.ParentID
local = false
fyrchik commented 2025-04-09 14:23:55 +00:00
Owner
Copy link

You check whether parent object can be headed.
This won't work if we have exactly the last chunk needed to construct HEAD, as the local node is down.
I believe more correct approach is to perform raw head and consider ECInfoError a witness of object existence.

You check whether parent object can be headed. This won't work if we have exactly the last chunk needed to construct HEAD, as the local node is down. I believe more correct approach is to perform `raw` head and consider `ECInfoError` a witness of object existence.
dstepanov-yadro commented 2025-04-09 15:27:27 +00:00
Author
Member
Copy link

Fixed

Fixed
dstepanov-yadro force-pushed zombie_162 from dcd05a02e7 to 26a94a767a 2025-04-09 14:46:15 +00:00 Compare
aarifullin approved these changes 2025-04-09 15:02:28 +00:00
aarifullin left a comment
Member
Copy link

Excellent

Excellent
dstepanov-yadro added 1 commit 2025-04-10 13:08:54 +00:00
[#9999] adm: Drop rpc-endpoint flag from zombie scan
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 1m1s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m24s
Details
DCO action / DCO (pull_request) Successful in 1m43s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m36s
Details
Tests and linters / Lint (pull_request) Successful in 2m40s
Details
Build / Build Components (pull_request) Successful in 2m52s
Details
Tests and linters / gopls check (pull_request) Failing after 3m14s
Details
Tests and linters / Tests (pull_request) Successful in 4m23s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m32s
Details
0886241ee0 
Morph addresses from config are used.

Change-Id: I6b93c638a1366ad952e5210569c6d9d9a9c35889
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 1m1s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m24s
Details
DCO action / DCO (pull_request) Successful in 1m43s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m36s
Details
Tests and linters / Lint (pull_request) Successful in 2m40s
Details
Build / Build Components (pull_request) Successful in 2m52s
Details
Tests and linters / gopls check (pull_request) Failing after 3m14s
Details
Tests and linters / Tests (pull_request) Successful in 4m23s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m32s
Details
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u zombie_162:dstepanov-yadro-zombie_162
git checkout dstepanov-yadro-zombie_162
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1711
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:zombie_162"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?