morph: use blocking unlimited pool for notifications #198

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:fix-do-not-drop-epoch into master 2023-04-03 15:58:23 +00:00
Owner

Close #195.

With non-blocking pool restricted by 10 in capacity, the probability of
dropping events is unexpectedly big. Notifications are an essential part of the FrostFS,
we should not drop anything, especially new epochs.

Mar 31 07:07:03 vedi neofs-ir[19164]: 2023-03-31T07:07:03.901Z        debug        subscriber/subscriber.go:154        new notification event from sidechain        {"name": "NewEpoch"}
Mar 31 07:07:03 vedi neofs-ir[19164]: 2023-03-31T07:07:03.901Z        warn        event/listener.go:248        listener worker pool drained        {"chain": "morph", "capacity": 10}
Close #195. With non-blocking pool restricted by 10 in capacity, the probability of dropping events is unexpectedly big. Notifications are an essential part of the FrostFS, we should not drop anything, especially new epochs. ``` Mar 31 07:07:03 vedi neofs-ir[19164]: 2023-03-31T07:07:03.901Z debug subscriber/subscriber.go:154 new notification event from sidechain {"name": "NewEpoch"} Mar 31 07:07:03 vedi neofs-ir[19164]: 2023-03-31T07:07:03.901Z warn event/listener.go:248 listener worker pool drained {"chain": "morph", "capacity": 10} ```
fyrchik requested review from storage-core-developers 2023-04-03 08:23:51 +00:00
fyrchik requested review from storage-core-committers 2023-04-03 08:23:51 +00:00
fyrchik force-pushed fix-do-not-drop-epoch from f6fd0b4a4c to 03bef2bc98 2023-04-03 08:24:06 +00:00 Compare
dstepanov-yadro approved these changes 2023-04-03 08:30:22 +00:00
acid-ant approved these changes 2023-04-03 14:24:10 +00:00
fyrchik merged commit 0948a280fa into master 2023-04-03 15:58:22 +00:00
fyrchik deleted branch fix-do-not-drop-epoch 2023-04-03 15:58:24 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#198
No description provided.