Allow to export metrics list to a file #214

fyrchik · 2023-04-05T10:49:38Z

fyrchik commented

2023-04-05 10:49:38 +00:00

Close #164.

$ go run ./scripts/export-metrics/main.go -node node.out
$ jq '.[0]' node.out
{
  "name": "frostfs_node_object_get_req_count_success",
  "help": "The number of successful get requests processed",
  "type": "COUNTER"
}

Close #164. ``` $ go run ./scripts/export-metrics/main.go -node node.out $ jq '.[0]' node.out { "name": "frostfs_node_object_get_req_count_success", "help": "The number of successful get requests processed", "type": "COUNTER" } ```

fyrchik requested review from storage-core-developers 2023-04-05 10:49:45 +00:00

fyrchik requested review from storage-core-committers 2023-04-05 10:49:45 +00:00

fyrchik requested review from alexvanin 2023-04-05 10:49:55 +00:00

fyrchik requested review from dkirillov 2023-04-05 10:49:59 +00:00

fyrchik requested review from pogpp 2023-04-05 10:50:08 +00:00

fyrchik requested review from ironbee 2023-04-05 10:50:13 +00:00

fyrchik requested review from realloc 2023-04-05 10:52:22 +00:00

dstepanov-yadro reviewed 2023-04-05 12:57:15 +00:00

pkg/metrics/desc.go Outdated

					
				@ -0,0 +75,4 @@

					for pd := range ch {

						d, err := parseDesc(pd)

						if err != nil {

							return nil, err

dstepanov-yadro commented

2023-04-05 12:57:11 +00:00

Looks like memleak in case of error. goroutine knows nothing about return (no channel readers) and will try to call collectors[i].Describe(ch)

Looks like memleak in case of error. goroutine knows nothing about `return` (no channel readers) and will try to call `collectors[i].Describe(ch)`

fyrchik commented

2023-04-07 05:00:38 +00:00

Fixed

dstepanov-yadro marked this conversation as resolved

alexvanin referenced this pull request from TrueCloudLab/frostfs-http-gw

2023-04-06 09:11:43 +00:00

Collect metrics descriptions for SNMP integration #29

alexvanin referenced this pull request from TrueCloudLab/frostfs-s3-gw

2023-04-06 09:21:40 +00:00

Collect metrics descriptions for SNMP integration #80

alexvanin reviewed 2023-04-06 14:01:54 +00:00

scripts/export-metrics/main.go Outdated

					
				@ -0,0 +15,4 @@

					ir   = flag.String("ir", "", "File to export innerring node metrics to.")

				)

				func main() {

alexvanin commented

2023-04-06 14:01:54 +00:00

What you think about having a couple of unit tests in metrics package that print list of metrics for IR and Storage into stdout instead of having a separate application? These tests can be ignored with build tag.

fyrchik commented

2023-04-06 15:54:30 +00:00

I like the idea, but I've thought we need to integrate it into some pipeline.
Probably some go:generate is enough, though.

I like the idea, but I've thought we need to integrate it into some pipeline. Probably some `go:generate` is enough, though.

fyrchik marked this conversation as resolved

fyrchik force-pushed metrics-refactor from dbe9618987 to e58f2253fc

2023-04-07 05:00:00 +00:00

Compare

fyrchik force-pushed metrics-refactor from e58f2253fc to 9c53071e2f

2023-04-07 12:13:11 +00:00

Compare

fyrchik force-pushed metrics-refactor from 9c53071e2f to 63cd97c783