Allow to export metrics list to a file #214
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#214
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "fyrchik/frostfs-node:metrics-refactor"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Close #164.
@ -0,0 +75,4 @@
for pd := range ch {
d, err := parseDesc(pd)
if err != nil {
return nil, err
Looks like memleak in case of error. goroutine knows nothing about
return
(no channel readers) and will try to callcollectors[i].Describe(ch)
Fixed
@ -0,0 +15,4 @@
ir = flag.String("ir", "", "File to export innerring node metrics to.")
)
func main() {
What you think about having a couple of unit tests in metrics package that print list of metrics for IR and Storage into stdout instead of having a separate application? These tests can be ignored with build tag.
I like the idea, but I've thought we need to integrate it into some pipeline.
Probably some
go:generate
is enough, though.dbe9618987
toe58f2253fc
e58f2253fc
to9c53071e2f
9c53071e2f
to63cd97c783
63cd97c783
toa693a8db26
WIP: Allow to export metrics list to a fileto Allow to export metrics list to a filea693a8db26
to3246500249
3246500249
toc70306b324