TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 93 Pull requests 4 Projects Releases 1 Activity Actions

Multiple copy numbers #221

Merged
fyrchik merged 1 commit from feat/multiple-copies-number into master 2023-05-05 16:07:14 +00:00
Conversation 1 Commits 1 Files changed 4 +40 -8
carpawell commented 2023-04-05 21:46:02 +00:00
Contributor
Copy link

Blocked by TrueCloudLab/frostfs-sdk-go#46.

Implementation might have to be changed according to TrueCloudLab/frostfs-sdk-go#45 discussion.

Blocked by https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/46. Implementation might have to be changed according to https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/45 discussion.
carpawell force-pushed feat/multiple-copies-number from 3648ff99b4 to 85430af1ac 2023-04-11 18:01:12 +00:00 Compare
carpawell changed title from WIP: Multiple copy numbers to Multiple copy numbers 2023-04-11 18:22:51 +00:00
carpawell force-pushed feat/multiple-copies-number from 85430af1ac to 0720550a74 2023-04-11 18:25:11 +00:00 Compare
carpawell requested review from storage-core-committers 2023-04-11 18:26:56 +00:00
carpawell requested review from storage-core-developers 2023-04-11 18:26:56 +00:00
carpawell requested review from fyrchik 2023-04-11 18:27:00 +00:00
dstepanov-yadro requested changes 2023-04-12 06:58:16 +00:00
pkg/services/object/put/v2/streamer.go Outdated
@ -144,3 +144,3 @@
var stream *rpc.PutRequestWriter
err = c.RawForAddress(addr, func(cli *rawclient.Client) error {
err = c.RawForAddress(context.Background(), addr, func(cli *rawclient.Client) error {
dstepanov-yadro commented 2023-04-12 06:57:24 +00:00
Member
Copy link

I think context.TODO() is better. context.Background() means that we don't need parent context. But for this case, in the bright future, we will use the parent context.

I think `context.TODO()` is better. `context.Background()` means that we don't need parent context. But for this case, in the bright future, we will use the parent context.
carpawell commented 2023-04-12 07:35:46 +00:00
Author
Contributor
Copy link

agree, fixed

agree, fixed
dstepanov-yadro marked this conversation as resolved
carpawell force-pushed feat/multiple-copies-number from 0720550a74 to 90ac80e433 2023-04-12 07:38:09 +00:00 Compare
carpawell requested review from dstepanov-yadro 2023-04-12 07:38:19 +00:00
carpawell requested review from storage-core-developers 2023-04-12 07:38:26 +00:00
dstepanov-yadro approved these changes 2023-04-12 09:36:32 +00:00
acid-ant approved these changes 2023-04-12 10:06:15 +00:00
carpawell added the due date 2023-04-21 2023-04-17 14:12:24 +00:00
fyrchik approved these changes 2023-04-21 09:47:05 +00:00
pkg/services/object/put/v2/streamer.go Outdated
@ -144,3 +144,3 @@
var stream *rpc.PutRequestWriter
err = c.RawForAddress(addr, func(cli *rawclient.Client) error {
err = c.RawForAddress(context.TODO(), addr, func(cli *rawclient.Client) error {
fyrchik commented 2023-04-13 04:56:47 +00:00
Owner
Copy link

Do we have an issue?

Do we have an issue?
carpawell commented 2023-05-04 14:57:39 +00:00
Author
Contributor
Copy link

that line problem somehow disappeared (well, hehe, thanks to @dstepanov-yadro)

_that line_ problem somehow disappeared (well, hehe, thanks to @dstepanov-yadro)
pkg/services/object_manager/placement/traverser.go Outdated
@ -87,0 +88,4 @@
// backward compatibility for scalar `copies_number`
if len(cfg.copyNumbers) == 1 {
cn := cfg.copyNumbers[0]
cfg.flatSuccess = &cn
fyrchik commented 2023-04-13 04:45:33 +00:00
Owner
Copy link

Can't we just take address of the first element directly?

Can't we just take address of the first element directly?
carpawell commented 2023-05-04 14:58:50 +00:00
Author
Contributor
Copy link

usually try not to do that but it looks safe here, fixed

usually try not to do that but it looks safe here, fixed
pkg/services/object_manager/placement/traverser.go Outdated
@ -94,6 +101,11 @@ func NewTraverser(opts ...Option) (*Traverser, error) {
for i := 0; i < replNum; i++ {
if cfg.trackCopies {
if len(cfg.copyNumbers) > i {
fyrchik commented 2023-04-13 04:50:38 +00:00
Owner
Copy link

What about creating default vector with ReplicaNumberByIndex elements and removing special case here?

What about creating default vector with `ReplicaNumberByIndex` elements and removing special case here?
carpawell commented 2023-05-04 14:58:16 +00:00
Author
Contributor
Copy link

hope i got you right and fixed but double check that, please

hope i got you right and fixed but double check that, please
fyrchik commented 2023-05-04 07:12:41 +00:00
Owner
Copy link

@carpawell rebase, please

@carpawell rebase, please
👍 1
carpawell force-pushed feat/multiple-copies-number from 90ac80e433 to 604ca51264 2023-05-04 15:00:02 +00:00 Compare
carpawell requested review from fyrchik 2023-05-04 15:00:47 +00:00
fyrchik approved these changes 2023-05-05 16:07:08 +00:00
fyrchik merged commit ee58b390bb into master 2023-05-05 16:07:14 +00:00
fyrchik deleted branch feat/multiple-copies-number 2023-05-05 16:07:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2023-04-21

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#221
No description provided.
Delete branch "feat/multiple-copies-number"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?