TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

Refactor audit service #222

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:refactoring/object-3610-audit into master 2023-07-26 21:07:57 +00:00
Conversation 0 Commits 1 Files changed 1 +27 -16
dstepanov-yadro commented 2023-04-06 09:23:34 +00:00
Member
Copy link

Resolve linters

Resolve linters
dstepanov-yadro force-pushed refactoring/object-3610-audit from bc50105195 to c631f5b904 2023-04-06 09:24:38 +00:00 Compare
dstepanov-yadro changed title from WIP: Refactor audit service to Refactor audit service 2023-04-06 09:24:44 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-04-06 09:24:49 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-04-06 09:24:49 +00:00
fyrchik approved these changes 2023-04-06 11:00:15 +00:00
pkg/innerring/processors/audit/process.go Outdated
@ -49,2 +49,2 @@
var auditCtx context.Context
auditCtx, ap.prevAuditCanceler = context.WithCancel(context.Background())
cancelChannel := make(chan struct{})
ap.prevAuditCanceler = func() {
fyrchik commented 2023-04-06 10:57:37 +00:00
Owner
Copy link

Can we describe somewhere (prevAuditCanceler doc?) that this function is (must) be called only once?

Can we describe somewhere (`prevAuditCanceler` doc?) that this function is (must) be called only once?
dstepanov-yadro commented 2023-04-06 12:14:54 +00:00
Author
Member
Copy link

Oh, it's my mistake that this function should be called once. Fixed.

Oh, it's my mistake that this function should be called once. Fixed.
fyrchik marked this conversation as resolved
pkg/services/audit/taskmanager/listen.go Outdated
@ -37,0 +39,4 @@
select {
case <-tCtx.Done(): // listen cancelled
return
case <-task.CancelChannel(): // new epoch
fyrchik commented 2023-04-06 10:59:49 +00:00
Owner
Copy link

Handle task can exit with errors without closing the channel. Is my understanding right: this goroutine will continue to hang until the next epoch when we cancel previous audit explicitly?

Handle task can exit with errors without closing the channel. Is my understanding right: this goroutine will continue to hang until the next epoch when we cancel previous audit explicitly?
dstepanov-yadro commented 2023-04-06 12:15:39 +00:00
Author
Member
Copy link

Fixed.

Fixed.
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed refactoring/object-3610-audit from c631f5b904 to 53e4449cb9 2023-04-06 12:08:04 +00:00 Compare
fyrchik approved these changes 2023-04-07 04:45:51 +00:00
acid-ant approved these changes 2023-04-07 09:49:51 +00:00
dstepanov-yadro force-pushed refactoring/object-3610-audit from 53e4449cb9 to e2f13d03d7 2023-04-07 14:29:37 +00:00 Compare
fyrchik approved these changes 2023-04-07 14:48:32 +00:00
fyrchik merged commit e2f13d03d7 into master 2023-04-07 14:48:42 +00:00
fyrchik referenced this pull request from a commit 2023-04-07 14:48:42 +00:00
[#222] auditsvc: Refactor audit task
fyrchik referenced this pull request from a commit 2023-04-07 14:48:42 +00:00
[#222] auditsvc: Refactor PoR audit
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#222
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:refactoring/object-3610-audit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?