TrueCloudLab
/
frostfs-node
17
1
Fork 21
Code Issues 89 Pull Requests 8 Actions Projects Releases Activity

Fix/Actualize notary requests parsing #268

Merged
fyrchik merged 1 commits from fix/notary-preparator-is-outdated into master 2023-04-20 07:37:14 +00:00
Conversation 0 Commits 1 Files Changed 2
carpawell commented 2023-04-19 14:12:09 +00:00
Collaborator

After 75d7891ca1
neo-go does claim that an empty invocation script is the only way to
fill missing signature for unsigned notary requests. The new notary actor
does it that way and, therefore, breaks notary request parsing by the
Alphabet because of skipping any request that is not filled with a dummy (64
zeros) invocation script. Support both way. The "Dummy" approach will be
dropped later.

Signed-off-by: Pavel Karpy p.karpy@yadro.com

After https://github.com/nspcc-dev/neo-go/commit/75d7891ca183f0e24b8fb13d21b7076a95ddebbd `neo-go` does claim that an empty invocation script is the only way to fill missing signature for unsigned notary requests. The new notary actor does it that way and, therefore, breaks notary request parsing by the Alphabet because of skipping any request that is not filled with a dummy (64 zeros) invocation script. Support both way. The "Dummy" approach will be dropped later. Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
carpawell self-assigned this 2023-04-19 14:12:09 +00:00
carpawell requested review from storage-core-developers 2023-04-19 14:12:28 +00:00
carpawell requested review from storage-core-committers 2023-04-19 14:12:29 +00:00
carpawell force-pushed fix/notary-preparator-is-outdated from 157086e88a to 3a3e0ac615 2023-04-19 14:12:30 +00:00 Compare
carpawell requested review from fyrchik 2023-04-19 14:12:34 +00:00
carpawell force-pushed fix/notary-preparator-is-outdated from 3a3e0ac615 to 2044803f8e 2023-04-19 14:13:59 +00:00 Compare
carpawell force-pushed fix/notary-preparator-is-outdated from 2044803f8e to 6591e97430 2023-04-19 14:16:17 +00:00 Compare
carpawell force-pushed fix/notary-preparator-is-outdated from 6591e97430 to 8178c04eae 2023-04-19 14:17:20 +00:00 Compare
acid-ant approved these changes 2023-04-20 06:28:31 +00:00
fyrchik approved these changes 2023-04-20 07:24:12 +00:00
carpawell force-pushed fix/notary-preparator-is-outdated from 8178c04eae to 4f5f832137 2023-04-20 07:29:47 +00:00 Compare
fyrchik approved these changes 2023-04-20 07:32:56 +00:00
fyrchik merged commit 4f5f832137 into master 2023-04-20 07:37:14 +00:00
fyrchik deleted branch fix/notary-preparator-is-outdated 2023-04-20 07:37:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
carpawell
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#268
There is no content yet.
Delete Branch "fix/notary-preparator-is-outdated"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?