TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

[#114] Add remove-node IR control command #310

Merged
fyrchik merged 1 commit from ale64bit/frostfs-node:feature/114-control-ir-remove-node into master 2023-05-10 14:31:45 +00:00
Conversation 0 Commits 1 Files changed 10 +157
ale64bit commented 2023-05-03 13:27:46 +00:00
Member
Copy link

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Close #114

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Close #114
ale64bit requested review from storage-core-committers 2023-05-03 13:28:00 +00:00
ale64bit requested review from storage-core-developers 2023-05-03 13:28:01 +00:00
acid-ant approved these changes 2023-05-03 15:26:10 +00:00
dstepanov-yadro reviewed 2023-05-04 14:22:33 +00:00
pkg/morph/client/netmap/peer.go Outdated
@ -0,0 +48,4 @@
return fmt.Errorf("peer can be forcefully removed only in notary environment")
}
prm := UpdatePeerPrm{}
dstepanov-yadro commented 2023-05-04 14:22:27 +00:00
Member
Copy link

NodeState = Offline ?

NodeState = Offline ?
dstepanov-yadro commented 2023-05-04 14:32:21 +00:00
Member
Copy link

Oh, my mistake:

	if p.state == 0 {
		p.state = netmap.NodeStateOffline
	}
Oh, my mistake: ``` if p.state == 0 { p.state = netmap.NodeStateOffline } ```
dstepanov-yadro marked this conversation as resolved
dstepanov-yadro reviewed 2023-05-04 14:24:44 +00:00
pkg/services/control/ir/server/calls.go Outdated
@ -60,0 +82,4 @@
break
}
}
if len(nodeInfo.PublicKey()) == 0 {
dstepanov-yadro commented 2023-05-04 14:24:44 +00:00
Member
Copy link

Maybe validate node state too? What if state already Offline?

Maybe validate node state too? What if state already Offline?
ale64bit commented 2023-05-04 14:52:14 +00:00
Author
Member
Copy link

would it appear in the list if it was offline?

would it appear in the list if it was offline?
dstepanov-yadro commented 2023-05-04 14:53:44 +00:00
Member
Copy link

I don't know)

I don't know)
ale64bit commented 2023-05-05 07:16:40 +00:00
Author
Member
Copy link

Added the check just in case.

Added the check just in case.
dstepanov-yadro marked this conversation as resolved
ale64bit force-pushed feature/114-control-ir-remove-node from f605f970fd to 229bb24cc7 2023-05-05 07:15:35 +00:00 Compare
dstepanov-yadro approved these changes 2023-05-05 08:51:24 +00:00
fyrchik approved these changes 2023-05-05 16:11:01 +00:00
cmd/frostfs-cli/modules/control/ir_remove_node.go Outdated
@ -0,0 +30,4 @@
pk := key.Get(cmd)
c := getClient(cmd, pk)
nodeKeyStr, _ := cmd.Flags().GetString("node")
fyrchik commented 2023-05-05 16:09:53 +00:00
Owner
Copy link

Can we just make a flag required? I know, you still can provide empty value, but hey, control service should still return an error.

Can we just make a flag required? I know, you still can provide empty value, but hey, control service should still return an error.
ale64bit commented 2023-05-10 06:55:55 +00:00
Author
Member
Copy link

done

done
fyrchik marked this conversation as resolved
pkg/morph/client/static.go Outdated
@ -175,3 +175,3 @@
}
// SetArgs sets arguments of the contact call.
// SetArgs sets arguments of the contract call.
fyrchik commented 2023-05-05 16:10:19 +00:00
Owner
Copy link

Unrelated to the commit.

Unrelated to the commit.
ale64bit commented 2023-05-10 06:56:01 +00:00
Author
Member
Copy link

done

done
fyrchik marked this conversation as resolved
ale64bit force-pushed feature/114-control-ir-remove-node from 229bb24cc7 to 8e5b7cb98e 2023-05-10 06:55:32 +00:00 Compare
fyrchik approved these changes 2023-05-10 14:31:21 +00:00
fyrchik merged commit 90799497d3 into master 2023-05-10 14:31:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#310
No description provided.
Delete branch "ale64bit/frostfs-node:feature/114-control-ir-remove-node"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?