[#324] Add replicator metrics #340

ale64bit · 2023-05-12T08:46:10Z

ale64bit commented

2023-05-12 08:46:10 +00:00

Signed-off-by: Alejandro Lopez a.lopez@yadro.com
Close #324

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Close #324

ale64bit requested review from storage-core-committers 2023-05-12 08:46:30 +00:00

ale64bit requested review from storage-core-developers 2023-05-12 08:46:30 +00:00

fyrchik approved these changes 2023-05-12 09:00:09 +00:00

fyrchik left a comment

As a nice correctness check, have you verified that scripts/metrics-exporter provides the metrics you added?

As a nice correctness check, have you verified that `scripts/metrics-exporter` provides the metrics you added?

pkg/services/replicator/process.go Outdated

					
				@ -70,2 +72,4 @@

							res.SubmitSuccessfulReplication(task.nodes[i])

							p.metrics.AddProcessedObjects(1)

fyrchik commented

2023-05-12 08:59:31 +00:00

Why not use Inc here?

Why not use `Inc` here?

ale64bit commented

2023-05-12 09:08:01 +00:00

done

fyrchik marked this conversation as resolved

ale64bit force-pushed feature/324-replicator-metrics from 57e169d144 to a4e10d943b

2023-05-12 09:07:52 +00:00

Compare

ale64bit commented

2023-05-12 09:08:28 +00:00

As a nice correctness check, have you verified that scripts/metrics-exporter provides the metrics you added?

I wasn't aware of that script. But they do appear:

{"name":"frostfs_node_replicator_in_flight_requests","help":"Number of in-flight requests","type":"GAUGE"},{"name":"frostfs_node_replicator_processed_objects","help":"Number of objects processed since the node startup","type":"COUNTER"},{"name":"frostfs_node_replicator_total_replicated_payload_size","help":"Total size of payloads replicated","type":"COUNTER"}

> As a nice correctness check, have you verified that `scripts/metrics-exporter` provides the metrics you added? I wasn't aware of that script. But they do appear: ``` {"name":"frostfs_node_replicator_in_flight_requests","help":"Number of in-flight requests","type":"GAUGE"},{"name":"frostfs_node_replicator_processed_objects","help":"Number of objects processed since the node startup","type":"COUNTER"},{"name":"frostfs_node_replicator_total_replicated_payload_size","help":"Total size of payloads replicated","type":"COUNTER"} ```

🚀 1

ale64bit force-pushed feature/324-replicator-metrics from a4e10d943b to 9f24c8666f

2023-05-12 09:40:41 +00:00

Compare

fyrchik approved these changes 2023-05-12 10:10:46 +00:00

dstepanov-yadro approved these changes 2023-05-12 10:47:42 +00:00

fyrchik merged commit a6ee7a3087 into master

2023-05-12 11:00:18 +00:00

Sign in to join this conversation.

No reviewers