TrueCloudLab/frostfs-node

WIP: Physically delete complex objects after expiration (Support) #345

Closed

dstepanov-yadro wants to merge 1 commit from dstepanov-yadro/frostfs-node:fix/complex_lifetime_support into support/v0.36

dstepanov-yadro commented

2023-05-12 16:01:25 +00:00

Member

Expired complex objects will be deleted by GC.

Expired complex objects will be deleted by GC.

dstepanov-yadro changed title from ~~WIP: Physically delete complex objects after expiration~~ to WIP: Physically delete complex objects after expiration (Support)

2023-05-12 16:01:35 +00:00

dstepanov-yadro force-pushed fix/complex_lifetime_support from 36219fc4c8 to ae4dab4bd8

2023-05-15 06:36:14 +00:00

Compare

JuliaKovshova approved these changes 2023-05-15 06:50:02 +00:00

aarifullin reviewed 2023-05-15 08:27:40 +00:00

pkg/local_object_storage/metabase/children.go

					
				@ -0,0 +22,4 @@

						for _, addr := range addresses {

							bkt := tx.Bucket(parentBucketName(addr.Container(), buffer[:]))

							if bkt == nil {

								result[addr] = nil

aarifullin commented

2023-05-15 08:27:40 +00:00

Member

I recommend to make this line more declarative using result[addr] = []oid.Address{} and fix the comment addr -> empty slice

I recommend to make this line more declarative using `result[addr] = []oid.Address{}` and fix the comment `addr -> empty slice`

aarifullin approved these changes 2023-05-15 08:30:58 +00:00

JuliaKovshova approved these changes 2023-05-17 09:15:25 +00:00

dstepanov-yadro closed this pull request

2023-05-17 09:25:41 +00:00

ci/woodpecker/pr/pre-commit Pipeline was successful

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#345

No description provided.