cli: Support copies number parameter in object put #350

acid-ant · 2023-05-15T12:26:31Z

acid-ant commented

2023-05-15 12:26:31 +00:00

Close #351

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #351 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant force-pushed feature/cli-obj-put-copies-num from e7dc990c5f to 84020bdf6a

2023-05-15 12:27:00 +00:00

Compare

acid-ant force-pushed feature/cli-obj-put-copies-num from 84020bdf6a to f3b45ca59b

2023-05-15 12:42:27 +00:00

Compare

acid-ant changed title from ~~WIP: cli: Support copies number parameter in object put~~ to cli: Support copies number parameter in object put

2023-05-15 12:42:55 +00:00

fyrchik reviewed 2023-05-15 12:45:49 +00:00

cmd/frostfs-cli/modules/object/put.go Outdated

					
				@ -57,2 +58,4 @@

					flags.String(notificationFlag, "", "Object notification in the form of *epoch*:*topic*; '-' topic means using default")

					flags.Bool(binaryFlag, false, "Deserialize object structure from given file.")

					flags.UintSlice(copiesNumberFlag, nil, "Number of copies of the object to store within the RPC call")

fyrchik commented

2023-05-15 12:45:16 +00:00

I believe UintSlice allows following usage: --copies-number 1 --copies-number 2.
It should be a bug, it is really and atomic vector and not an arbitrary-sized slice.
What about using String and split it by ,?

I believe `UintSlice` allows following usage: `--copies-number 1 --copies-number 2`. It should be a bug, it is really and _atomic_ vector and not an arbitrary-sized slice. What about using `String` and split it by `,`?

acid-ant commented

2023-05-15 13:05:44 +00:00

Surprised, will use string instead of uint slice.

acid-ant commented

2023-05-15 13:23:08 +00:00

Done, please review.