TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

[#325] node: Introduce unsafe_disable param to disable policer #383

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:feature/325-policer_off into master 2023-05-31 10:09:06 +00:00
Conversation 1 Commits 1 Files changed 3 +13 -1
aarifullin commented 2023-05-22 10:02:45 +00:00
Member
Copy link

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added the
enhancement
 label 2023-05-22 10:02:45 +00:00
aarifullin requested review from storage-core-developers 2023-05-22 10:02:58 +00:00
aarifullin requested review from storage-core-committers 2023-05-22 10:02:58 +00:00
acid-ant approved these changes 2023-05-22 10:07:19 +00:00
dstepanov-yadro approved these changes 2023-05-23 06:49:03 +00:00
fyrchik reviewed 2023-05-23 07:30:03 +00:00
cmd/frostfs-node/object.go Outdated
@ -205,2 +205,4 @@
func addPolicer(c *cfg, keyStorage *util.KeyStorage, clientConstructor *cache.ClientCache) {
if policerconfig.UnsafeDisable(c.appCfg) {
c.log.Info(logs.FrostFSNodePolicerIsDisabled)
fyrchik commented 2023-05-23 07:10:36 +00:00
Owner
Copy link

Can we do this with Warn level? It is probably a mistake, unless you know what you are doing, so can safely ignore the warning.

Can we do this with `Warn` level? It is probably a mistake, unless you know what you are doing, so can safely ignore the warning.
aarifullin commented 2023-05-23 15:47:56 +00:00
Author
Member
Copy link

OK

OK
aarifullin commented 2023-05-23 16:09:13 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
aarifullin force-pushed feature/325-policer_off from 5465717a86 to 6550968556 2023-05-23 16:09:02 +00:00 Compare
aarifullin requested review from acid-ant 2023-05-23 16:09:19 +00:00
aarifullin requested review from dstepanov-yadro 2023-05-23 16:09:19 +00:00
acid-ant approved these changes 2023-05-24 06:07:20 +00:00
dstepanov-yadro approved these changes 2023-05-24 06:44:40 +00:00
fyrchik reviewed 2023-05-24 07:38:33 +00:00
internal/logs/logs.go Outdated
@ -455,6 +455,7 @@ const (
FrostFSNodeNotificatorFinishedProcessingObjectNotifications = "notificator: finished processing object notifications" // Debug in ../node/cmd/frostfs-node/notificator.go
FrostFSNodeCouldNotWriteObjectNotification = "could not write object notification" // Warn in ../node/cmd/frostfs-node/notificator.go
FrostFSNodeCouldNotGetMaxObjectSizeValue = "could not get max object size value" // Error in ../node/cmd/frostfs-node/object.go
FrostFSNodePolicerIsDisabled = "policer is disabled" // Info in ../node/cmd/frostfs-node/object.go
fyrchik commented 2023-05-24 07:38:33 +00:00
Owner
Copy link

It's no longer Info

It's no longer `Info`
fyrchik commented 2023-05-25 10:47:42 +00:00
Owner
Copy link

cc @aarifullin

cc @aarifullin
fyrchik commented 2023-05-25 10:48:36 +00:00
Owner
Copy link

Also, as let's omit level in new logs -- initially it was autogenerated, I think we may need it less now (and now the information can be easily obtained with grep).

Also, as let's omit level in new logs -- initially it was autogenerated, I think we may need it less now (and now the information can be easily obtained with grep).
aarifullin commented 2023-05-26 09:26:56 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
aarifullin force-pushed feature/325-policer_off from 6550968556 to 8763e8aaf3 2023-05-26 09:26:37 +00:00 Compare
aarifullin requested review from acid-ant 2023-05-26 09:27:00 +00:00
aarifullin requested review from dstepanov-yadro 2023-05-26 09:27:04 +00:00
dstepanov-yadro approved these changes 2023-05-26 10:09:08 +00:00
acid-ant approved these changes 2023-05-26 11:21:22 +00:00
fyrchik commented 2023-05-26 13:40:03 +00:00
Owner
Copy link

@aarifullin there are conflicts with the main branch

@aarifullin there are conflicts with the main branch
aarifullin force-pushed feature/325-policer_off from 8763e8aaf3 to 22da65ac9c 2023-05-29 09:05:50 +00:00 Compare
aarifullin requested review from dstepanov-yadro 2023-05-29 09:06:02 +00:00
aarifullin requested review from acid-ant 2023-05-29 09:06:04 +00:00
dstepanov-yadro reviewed 2023-05-29 09:49:41 +00:00
internal/logs/logs.go Outdated
@ -479,2 +479,3 @@
FrostFSNodeCantListenGRPCEndpointControl = "can't listen gRPC endpoint (control)" // Error in ../node/cmd/frostfs-node/control.go
CommonApplicationStarted = "application started" // Info in ../node/cmd/frostfs-ir/main.go
FrostFSNodePolicerIsDisabled = "policer is disabled"
CommonApplicationStarted = "application started" // Info in ../node/cmd/frostfs-ir/main.go
dstepanov-yadro commented 2023-05-29 09:49:38 +00:00
Member
Copy link

Please delete // Info in ../node/cmd/frostfs-ir/main.go

Please delete `// Info in ../node/cmd/frostfs-ir/main.go`
👍 1
aarifullin force-pushed feature/325-policer_off from 22da65ac9c to e4afe0a565 2023-05-30 08:48:10 +00:00 Compare
dstepanov-yadro approved these changes 2023-05-30 13:11:06 +00:00
acid-ant approved these changes 2023-05-30 19:04:03 +00:00
fyrchik merged commit a3e30062df into master 2023-05-31 10:09:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#383
No description provided.
Delete branch "aarifullin/frostfs-node:feature/325-policer_off"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?