TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 11 Projects Releases 2 Activity Actions

Cancel GC is change mode requested #387

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/fix/cancel_gc_on_set_mode into master 2023-05-25 10:47:10 +00:00
Conversation 0 Commits 1 Files changed 7 +244 -65
dstepanov-yadro commented 2023-05-23 12:05:54 +00:00
Member
Copy link

GC can hold read lock for a long time. If change mode requested, GC should be cancelled.

GC can hold read lock for a long time. If change mode requested, GC should be cancelled.
dstepanov-yadro force-pushed fix/fix/cancel_gc_on_set_mode from 12807a9856 to 4539086621 2023-05-23 12:06:47 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-05-23 12:07:13 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-05-23 12:07:13 +00:00
acid-ant approved these changes 2023-05-23 12:07:41 +00:00
fyrchik reviewed 2023-05-24 11:42:45 +00:00
pkg/local_object_storage/shard/control.go Outdated
@ -338,0 +349,4 @@
}
func (s *Shard) lockExclusive() func() {
lockTaken := make(chan interface{})
fyrchik commented 2023-05-24 10:30:51 +00:00
Owner
Copy link

Why not struct{}?

Why not `struct{}`?
dstepanov-yadro commented 2023-05-24 14:39:37 +00:00
Author
Member
Copy link

no actual

no actual
fyrchik marked this conversation as resolved
pkg/local_object_storage/shard/delete.go Outdated
@ -79,3 +74,2 @@
if res.StorageID() != nil {
smalls[prm.addr[i]] = res.StorageID()
func (s *Shard) deleteObjectFromWriteCacheSafe(ctx context.Context, addr oid.Address) {
fyrchik commented 2023-05-24 10:31:53 +00:00
Owner
Copy link

What is the meaning of Safe in this context?

What is the meaning of `Safe` in this context?
dstepanov-yadro commented 2023-05-24 11:58:08 +00:00
Author
Member
Copy link

no error returned

no error returned
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed fix/fix/cancel_gc_on_set_mode from 4539086621 to e2e3127616 2023-05-24 12:41:34 +00:00 Compare
dstepanov-yadro force-pushed fix/fix/cancel_gc_on_set_mode from e2e3127616 to d4ca88de79 2023-05-24 12:54:50 +00:00 Compare
dstepanov-yadro reviewed 2023-05-24 12:55:40 +00:00
pkg/local_object_storage/shard/shard.go Outdated
@ -211,3 +215,3 @@
// hasWriteCache returns bool if write cache exists on shards.
func (s Shard) hasWriteCache() bool {
func (s *Shard) hasWriteCache() bool {
dstepanov-yadro commented 2023-05-24 12:55:40 +00:00
Author
Member
Copy link

govet linter: copylocks

govet linter: copylocks
👍 1
fyrchik approved these changes 2023-05-24 13:33:36 +00:00
aarifullin approved these changes 2023-05-24 15:30:12 +00:00
fyrchik approved these changes 2023-05-24 17:22:16 +00:00
dstepanov-yadro force-pushed fix/fix/cancel_gc_on_set_mode from d4ca88de79 to 2613351008 2023-05-25 06:38:46 +00:00 Compare
fyrchik approved these changes 2023-05-25 10:47:05 +00:00
fyrchik merged commit 2613351008 into master 2023-05-25 10:47:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#387
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/fix/cancel_gc_on_set_mode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?