[#374] Add inner-ring event metrics #405

ale64bit · 2023-05-29T09:05:37Z

ale64bit commented

2023-05-29 09:05:37 +00:00

Signed-off-by: Alejandro Lopez a.lopez@yadro.com
Close #374

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Close #374

ale64bit added 1 commit 2023-05-29 09:05:38 +00:00

[#374 ] Add inner-ring event metrics

ci/woodpecker/pr/pre-commit Pipeline was successful

Details

0f7d3219b8

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>

ale64bit requested review from storage-core-committers 2023-05-29 09:06:01 +00:00

ale64bit requested review from storage-core-developers 2023-05-29 09:06:01 +00:00

dstepanov-yadro approved these changes 2023-05-29 09:52:29 +00:00

fyrchik approved these changes 2023-05-29 10:16:27 +00:00

pkg/innerring/processors/util.go

					
				@ -0,0 +9,4 @@

				func SubmitEvent(pool *ants.Pool, metrics metrics.Register, eventLabel string, eventProcessor func() bool) error {

					return pool.Submit(func() {

						start := time.Now()

fyrchik commented

2023-05-29 10:15:26 +00:00

Why did you decide to have start here and not before we submit the task in pool?
Just asking.

Why did you decide to have `start` here and not _before_ we submit the task in pool? Just asking.

ale64bit commented

2023-05-29 12:47:47 +00:00

well, because my intention was to measure the actual event processor duration,
excluding whatever wait time it spends on the pool. The pool wait time is statistically unrelated to the event processor time for specific event types, and it can be measured separately if you think it's interesting.

well, because my intention was to measure the actual event processor duration, excluding whatever wait time it spends on the pool. The pool wait time is statistically unrelated to the event processor time for specific event types, and it can be measured separately if you think it's interesting.