TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Add GC metrics #407

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:feat/gc-metrics into master 2023-05-31 10:22:14 +00:00
Conversation 0 Commits 1 Files changed 7 +244 -26
dstepanov-yadro commented 2023-05-29 14:33:27 +00:00
Member
Copy link

Closes #376

Signed-off-by: Dmitrii Stepanov d.stepanov@yadro.com

Closes #376 Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro reviewed 2023-05-29 14:36:07 +00:00
pkg/metrics/gc.go Outdated
@ -0,0 +40,4 @@
func newGCMetrics() *gcMetrics {
return &gcMetrics{
runDuration: newCounterVec(prometheus.CounterOpts{
dstepanov-yadro commented 2023-05-29 14:36:07 +00:00
Author
Member
Copy link

Counter vector used for duration because

  1. GC can run 1 second or more than 1 minute, so using buckets will give us less information than counter

  2. GC runs as single process in the moment for shard

Counter vector used for duration because 1. GC can run 1 second or more than 1 minute, so using buckets will give us less information than counter 2. GC runs as single process in the moment for shard
👍 1
dstepanov-yadro requested review from storage-core-committers 2023-05-29 14:36:21 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-05-29 14:36:21 +00:00
fyrchik reviewed 2023-05-29 14:51:35 +00:00
pkg/local_object_storage/engine/shards.go Outdated
@ -108,0 +108,4 @@
shard.WithGCMetrics(
&gcMetrics{
storage: e.metrics.GC(),
shardID: id.String(),
fyrchik commented 2023-05-29 14:48:03 +00:00
Owner
Copy link

What about extending shard metrics interface with a GC() method?

What about extending shard metrics interface with a `GC()` method?
dstepanov-yadro commented 2023-05-29 15:22:43 +00:00
Author
Member
Copy link

Shard metrics look too complex already i think. So I would leave it like that, if you don't insist.

Shard metrics look too complex already i think. So I would leave it like that, if you don't insist.
fyrchik commented 2023-05-31 10:21:45 +00:00
Owner
Copy link

I mean the choice is between having a single "metrics" interface or multiple metric-related parameters, which feels klunky.
I don't insist, though.

I mean the choice is between having a single "metrics" interface or multiple metric-related parameters, which feels klunky. I don't insist, though.
fyrchik marked this conversation as resolved
pkg/metrics/gc.go Outdated
@ -0,0 +61,4 @@
inhumedCounter: newCounterVec(prometheus.CounterOpts{
Namespace: namespace,
Subsystem: gcSubsystem,
Name: "marked_to_removal_objects_count",
fyrchik commented 2023-05-29 14:50:38 +00:00
Owner
Copy link

for removal?

_for_ removal?
fyrchik commented 2023-05-29 14:50:59 +00:00
Owner
Copy link

Also, I think using inhumed_objects_count is also fine.

Also, I think using `inhumed_objects_count` is also fine.
dstepanov-yadro commented 2023-05-29 15:18:45 +00:00
Author
Member
Copy link

inhumed_objects_count was the first option. But in spec it calls mark

`inhumed_objects_count` was the first option. But in spec it calls `mark`
dstepanov-yadro commented 2023-05-29 15:23:47 +00:00
Author
Member
Copy link

for removal - fixed

for removal - fixed
dstepanov-yadro force-pushed feat/gc-metrics from 4a8ff6136f to 5c8e6215f8 2023-05-29 15:23:36 +00:00 Compare
acid-ant approved these changes 2023-05-29 19:16:23 +00:00
fyrchik approved these changes 2023-05-31 10:20:54 +00:00
fyrchik approved these changes 2023-05-31 10:22:09 +00:00
fyrchik merged commit 3220c4df9f into master 2023-05-31 10:22:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#407
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/gc-metrics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?