Extend evacuation logs #408

Merged

fyrchik merged 1 commits from dstepanov-yadro/frostfs-node:feat/evacuation_logs into master

2023-05-31 11:41:22 +00:00

dstepanov-yadro commented

2023-05-29 15:07:59 +00:00

Collaborator

Add operation-tag to logger.
Log evacuation results.

Closes #401

Add operation-tag to logger. Log evacuation results. Closes #401

dstepanov-yadro requested review from storage-core-committers 2023-05-29 15:08:06 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-05-29 15:08:06 +00:00

acid-ant approved these changes 2023-05-29 19:18:36 +00:00

fyrchik reviewed 2023-05-31 10:13:46 +00:00

pkg/local_object_storage/engine/evacuate.go Outdated

													
				@ -197,3 +197,3 @@

					}()

					e.log.Info(logs.EngineStartedShardsEvacuation, zap.Strings("shard_ids", shardIDs))

					e.log.Info(logs.EngineStartedShardsEvacuation, zap.Strings("shard_ids", shardIDs), zap.String("operation", "evacuation"))

fyrchik commented

2023-05-31 10:13:46 +00:00

Owner

Can we move evacuation to a constant? It is easy to miss typos on review.

Can we move `evacuation` to a constant? It is easy to miss typos on review.

fyrchik commented

2023-05-31 10:14:31 +00:00

Owner

Another option is to use log.With at the start of the evacuation.

Another option is to use `log.With` at the start of the evacuation.

dstepanov-yadro commented

2023-05-31 10:26:15 +00:00

Poster

Collaborator

Moved zap.String("operation", "evacuation") to var block

Moved zap.String("operation", "evacuation") to var block

dstepanov-yadro force-pushed feat/evacuation_logs from 48426ee7c8 to dbf41391b5

2023-05-31 10:25:34 +00:00

Compare

fyrchik approved these changes 2023-05-31 11:41:12 +00:00

fyrchik merged commit dbf41391b5 into master

2023-05-31 11:41:22 +00:00

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No Label

good first issue

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#408

There is no content yet.