TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

node: Add metrics for the error counter in the engine #418

Merged
realloc merged 1 commits from acid-ant/frostfs-node:feature/372-add-err-counter-shard into master 2023-06-07 13:04:48 +00:00
Conversation 0 Commits 1 Files Changed 6
acid-ant commented 2023-06-01 14:32:23 +00:00
Collaborator

Close #372

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #372 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2023-06-01 14:32:31 +00:00
acid-ant requested review from storage-core-developers 2023-06-01 14:32:32 +00:00
dstepanov-yadro requested changes 2023-06-02 06:55:49 +00:00
pkg/local_object_storage/engine/shards.go Outdated
@ -174,6 +186,8 @@ func (e *StorageEngine) removeShards(ids ...string) {
continue
}
sh.DeleteErrorCounter()
dstepanov-yadro commented 2023-06-02 06:55:45 +00:00
Collaborator

Scenario: There were 5 shards, one of them did not work due to errors. I deleted that shard so the server would continue to work normal. After that, I decided to investigate, but there is no metrics for this shard.

So i think we should not delete metrics when delete shard.

Scenario: There were 5 shards, one of them did not work due to errors. I deleted that shard so the server would continue to work normal. After that, I decided to investigate, but there is no metrics for this shard. So i think we should not delete metrics when delete shard.
👍 1
dstepanov-yadro marked this conversation as resolved
ale64bit reviewed 2023-06-02 07:01:29 +00:00
pkg/local_object_storage/engine/engine.go Outdated
@ -132,6 +132,7 @@ func (e *StorageEngine) reportShardErrorBackground(id string, msg string, err er
}
errCount := sh.errorCount.Add(1)
sh.Shard.AddToErrorCounter(1)
ale64bit commented 2023-06-02 07:01:25 +00:00
Collaborator

consider using Inc if it's always 1

consider using `Inc` if it's always 1
acid-ant commented 2023-06-02 08:21:54 +00:00
Poster
Collaborator

Thanks, renamed.

Thanks, renamed.
ale64bit commented 2023-06-02 08:29:56 +00:00
Collaborator

Sorry, what I meant was that if the increment is always one, we can simply remove the delta everywhere and use the Inc method, e.g.:


func (m engineMetrics) IncErrorCounter(shardID string) {
	m.errorCounter.value.With(prometheus.Labels{shardIDLabelKey: shardID}).Inc()
}

But up to you, whether we will need the delta later.

Sorry, what I meant was that if the increment is always one, we can simply remove the delta everywhere and use the `Inc` method, e.g.: ``` func (m engineMetrics) IncErrorCounter(shardID string) { m.errorCounter.value.With(prometheus.Labels{shardIDLabelKey: shardID}).Inc() } ``` But up to you, whether we will need the `delta` later.
acid-ant commented 2023-06-02 09:01:57 +00:00
Poster
Collaborator

Agree, renamed in all places.

Agree, renamed in all places.
👍 1
ale64bit marked this conversation as resolved
pkg/local_object_storage/shard/metrics_test.go Outdated
@ -71,0 +73,4 @@
m.errCounter += delta
}
func (m *metricsStore) ClearErrorCounter() {
ale64bit commented 2023-06-02 07:00:10 +00:00
Collaborator

do we really need two functions that do the same with different names?

do we really need two functions that do the same with different names?
acid-ant commented 2023-06-02 08:23:42 +00:00
Poster
Collaborator

It is in tests, and it is necessary to implement two methods ClearErrorCounter and DeleteErrorCounter for type metricsStore somehow.

It is in tests, and it is necessary to implement two methods `ClearErrorCounter` and `DeleteErrorCounter` for type `metricsStore` somehow.
👍 1
ale64bit marked this conversation as resolved
dstepanov-yadro approved these changes 2023-06-02 07:03:21 +00:00
acid-ant force-pushed feature/372-add-err-counter-shard from 9268c1a3d4 to 0272740848 2023-06-02 08:21:41 +00:00 Compare
ale64bit approved these changes 2023-06-02 08:30:06 +00:00
acid-ant force-pushed feature/372-add-err-counter-shard from 0272740848 to f12e080310 2023-06-02 09:01:13 +00:00 Compare
acid-ant force-pushed feature/372-add-err-counter-shard from f12e080310 to 92de822be1 2023-06-02 12:29:52 +00:00 Compare
acid-ant force-pushed feature/372-add-err-counter-shard from 92de822be1 to 05bf2a885e 2023-06-02 12:30:20 +00:00 Compare
acid-ant force-pushed feature/372-add-err-counter-shard from 05bf2a885e to 7f8f7702fa 2023-06-02 12:37:35 +00:00 Compare
acid-ant requested review from dstepanov-yadro 2023-06-02 12:40:13 +00:00
acid-ant requested review from ale64bit 2023-06-02 12:40:15 +00:00
dstepanov-yadro approved these changes 2023-06-02 14:40:01 +00:00
acid-ant requested review from storage-core-developers 2023-06-05 06:33:40 +00:00
acid-ant requested review from dstepanov-yadro 2023-06-05 06:33:51 +00:00
dstepanov-yadro approved these changes 2023-06-05 06:53:01 +00:00
ale64bit approved these changes 2023-06-05 10:53:29 +00:00
aarifullin approved these changes 2023-06-05 10:59:44 +00:00
acid-ant scheduled this pull request to auto merge when all checks succeed 2023-06-05 11:20:59 +00:00
alexvanin approved these changes 2023-06-05 11:23:13 +00:00
dstepanov-yadro approved these changes 2023-06-07 07:54:36 +00:00
dstepanov-yadro scheduled this pull request to auto merge when all checks succeed 2023-06-07 07:55:11 +00:00
acid-ant scheduled this pull request to auto merge when all checks succeed 2023-06-07 09:35:32 +00:00
acid-ant canceled auto merging this pull request when all checks succeed 2023-06-07 09:37:16 +00:00
realloc merged commit 263c6fdc50 into master 2023-06-07 13:04:48 +00:00
realloc deleted branch feature/372-add-err-counter-shard 2023-06-07 13:04:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ale64bit
aarifullin
alexvanin
dstepanov-yadro
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#418
There is no content yet.
Delete Branch "acid-ant/frostfs-node:feature/372-add-err-counter-shard"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?