TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

[#17] Add morph client metrics #436

Merged
fyrchik merged 1 commit from ale64bit/frostfs-node:feature/17-morph-client-metrics into master 2023-06-13 11:12:43 +00:00
Conversation 3 Commits 1 Files changed 11 +182 -15
ale64bit commented 2023-06-08 13:44:29 +00:00
Member
Copy link

Signed-off-by: Alejandro Lopez a.lopez@yadro.com
Closes #17

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Closes #17
ale64bit requested review from storage-core-committers 2023-06-08 13:44:45 +00:00
ale64bit requested review from storage-core-developers 2023-06-08 13:44:45 +00:00
ale64bit force-pushed feature/17-morph-client-metrics from ed6a13ebc2 to 2a012c9637 2023-06-08 13:49:10 +00:00 Compare
dstepanov-yadro reviewed 2023-06-09 14:59:35 +00:00
pkg/innerring/state.go Outdated
@ -31,3 +31,2 @@
s.epochCounter.Store(val)
if s.metrics != nil {
s.metrics.SetEpoch(val)
if s.irMetrics != nil {
dstepanov-yadro commented 2023-06-09 14:59:34 +00:00
Member
Copy link

Looks like this nil-check is not actual

Looks like this nil-check is not actual
ale64bit commented 2023-06-13 07:07:55 +00:00
Author
Member
Copy link

what do you mean?

what do you mean?
dstepanov-yadro approved these changes 2023-06-09 15:00:59 +00:00
acid-ant approved these changes 2023-06-13 05:29:51 +00:00
fyrchik approved these changes 2023-06-13 09:56:46 +00:00
pkg/innerring/innerring.go Outdated
@ -331,1 +332,3 @@
metrics: metrics.NewInnerRingMetrics(),
log: log,
irMetrics: metrics.NewInnerRingMetrics(),
morphMetrics: metrics.NewMorphClientMetrics(),
fyrchik commented 2023-06-13 09:54:36 +00:00
Owner
Copy link

I may be missing something, but where do we actually use it?

I may be missing something, but where do we actually use it?
ale64bit commented 2023-06-13 10:06:56 +00:00
Author
Member
Copy link

indeed, I forgot it when I moved the initialization to initMorphComponents. Would be nice to lint these somehow. Fixed.

indeed, I forgot it when I moved the initialization to `initMorphComponents`. Would be nice to lint these somehow. Fixed.
fyrchik commented 2023-06-13 10:24:39 +00:00
Owner
Copy link

I thought they should be linted, but turns out no, neither structcheck nor unused do this.

I thought they should be linted, but turns out no, neither `structcheck` nor `unused` do this.
pkg/metrics/morph.go Outdated
@ -0,0 +76,4 @@
morphInvokeTypeLabel: typ,
morphContractLabel: contract,
morphMethodLabel: method,
morphSuccessLabel: fmt.Sprintf("%v", success),
fyrchik commented 2023-06-13 09:56:22 +00:00
Owner
Copy link

strconv.FormatBool?

`strconv.FormatBool`?
ale64bit commented 2023-06-13 10:08:07 +00:00
Author
Member
Copy link

done. Although I also prefer strconv.FormatBool since there's no room for a type mismatch, we seem to use both ways inconsistently.

done. Although I also prefer `strconv.FormatBool` since there's no room for a type mismatch, we seem to use both ways inconsistently.
fyrchik commented 2023-06-13 10:23:58 +00:00
Owner
Copy link

#442

https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/442
👍 1
fyrchik marked this conversation as resolved
ale64bit force-pushed feature/17-morph-client-metrics from 2a012c9637 to 9688d310bc 2023-06-13 10:06:18 +00:00 Compare
fyrchik commented 2023-06-13 10:12:51 +00:00
Owner
Copy link

Please, resolve conflicts.

Please, resolve conflicts.
ale64bit commented 2023-06-13 10:41:52 +00:00
Author
Member
Copy link

Please, resolve conflicts.

is master borked?

> Please, resolve conflicts. is `master` borked?
ale64bit force-pushed feature/17-morph-client-metrics from 9688d310bc to 4887f489a1 2023-06-13 11:06:16 +00:00 Compare
ale64bit commented 2023-06-13 11:06:53 +00:00
Author
Member
Copy link

Rebased and added MetricsRegister back.

Rebased and added `MetricsRegister` back.
fyrchik merged commit 4887f489a1 into master 2023-06-13 11:12:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#436
No description provided.
Delete branch "ale64bit/frostfs-node:feature/17-morph-client-metrics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?