Feature/44 multiple configs #45

Merged

KirillovDenis merged 5 commits from feature/44-multiple_configs into master

2023-02-21 07:00:29 +00:00

KirillovDenis commented

2023-02-06 14:56:54 +00:00

(Migrated from github.com)

close #44

close #44

alexvanin (Migrated from github.com) reviewed 2023-02-06 14:56:54 +00:00

realloc (Migrated from github.com) reviewed 2023-02-06 14:56:54 +00:00

carpawell (Migrated from github.com) reviewed 2023-02-06 14:56:54 +00:00

acid-ant (Migrated from github.com) reviewed 2023-02-06 14:56:54 +00:00

fyrchik (Migrated from github.com) reviewed 2023-02-06 18:03:12 +00:00

config/example/README.md

fyrchik (Migrated from github.com) commented

2023-02-06 17:56:42 +00:00

Can we explicitly specify how we resolve conflicts if the same field is present in multiple files?

Can we explicitly specify how we resolve conflicts if the same field is present in multiple files?

config/example/node.yaml

fyrchik (Migrated from github.com) commented

2023-02-06 17:58:58 +00:00

Please, let's leave example as it is. It's purpose is to demonstrate a possible configuration, not to illustrate this feature. All tests can reside in pkg/util/config.

Please, let's leave example as it is. It's purpose is to demonstrate a possible configuration, not to illustrate this feature. All tests can reside in `pkg/util/config`.

KirillovDenis (Migrated from github.com) reviewed 2023-02-07 06:13:43 +00:00

config/example/node.yaml

KirillovDenis (Migrated from github.com) commented

2023-02-07 06:13:43 +00:00

Whoops, accidentally committed

Whoops, accidentally committed

fyrchik (Migrated from github.com) reviewed 2023-02-17 09:02:18 +00:00

config/example/README.md

fyrchik (Migrated from github.com) commented

2023-02-17 09:02:18 +00:00

I've meant we should clarify and then give an example. Like "if a field is specified in multiple files, the latest occurence takes effect."

I've meant we should clarify and then give an example. Like "if a field is specified in multiple files, the latest occurence takes effect."

fyrchik (Migrated from github.com) reviewed 2023-02-17 09:02:55 +00:00

config/example/shards/shard0.yaml

fyrchik (Migrated from github.com) commented

2023-02-17 09:02:55 +00:00

Forgot to remove?

Forgot to remove?

KirillovDenis (Migrated from github.com) reviewed 2023-02-20 11:15:35 +00:00

config/example/shards/shard0.yaml

KirillovDenis (Migrated from github.com) commented

2023-02-20 11:15:35 +00:00

No. We have to specify full path to the config field

No. We have to specify full path to the config field

fyrchik (Migrated from github.com) reviewed 2023-02-20 11:26:11 +00:00

config/example/shards/shard0.yaml

fyrchik (Migrated from github.com) commented

2023-02-20 11:26:10 +00:00

I've meant a file, speaking about this comment https://github.com/TrueCloudLab/frostfs-node/pull/45#discussion_r1097738834

I've meant a file, speaking about this comment https://github.com/TrueCloudLab/frostfs-node/pull/45#discussion_r1097738834

KirillovDenis (Migrated from github.com) reviewed 2023-02-20 11:46:50 +00:00

config/example/shards/shard0.yaml

KirillovDenis (Migrated from github.com) commented

2023-02-20 11:46:50 +00:00

Oh, you meant all new config files. Ok

Oh, you meant all new config files. Ok

fyrchik (Migrated from github.com) approved these changes 2023-02-21 06:58:33 +00:00

fyrchik (Migrated from github.com) approved these changes 2023-02-21 07:00:16 +00:00

Sign in to join this conversation.

No reviewers

No Label

good first issue

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#45

There is no content yet.