TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 10 Projects Releases 2 Activity Actions

WIP: [#469] cli: Fix bug with name option for container list command #469

Closed
aarifullin wants to merge 1 commit from aarifullin/frostfs-node:fix/113-list_name_flag into master
pull from: aarifullin/frostfs-node:fix/113-list_name_flag
merge into: TrueCloudLab:master
Conversation 2 Commits 1 Files changed 1 +2 -2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit ea5002d20b - Show all commits

4
cmd/frostfs-cli/modules/container/list.go
View file

@ -70,7 +70,7 @@ var listContainersCmd = &cobra.Command{
}
cnr := res.Container()
if cnrName := containerSDK.Name(cnr); flagVarListName != "" && cnrName != flagVarListName {
if cnrName := containerSDK.Name(cnr); flagVarListName != "" && !strings.Contains(cnrName, flagVarListName) {
fyrchik commented 2023-06-27 07:23:56 +00:00
Outdated
Review
Copy link

Well, we also had #224 (comment)
I think we need to change the help instead.

Well, we also had https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/224#issuecomment-5234 I think we need to change the help instead.
aarifullin commented 2023-06-27 08:53:58 +00:00
Outdated
Review
Copy link

Fixed. Anyway, it seems that using not whole name but its part is also useful

Fixed. Anyway, it seems that using not whole name but its part is also useful
fyrchik commented 2023-06-28 06:47:27 +00:00
Outdated
Review
Copy link

This could be useful, but also makes it impossible to search for the exact name.
The exact name was the original requirement for this task #113

This could be useful, but also makes it impossible to search for the exact name. The exact name was the original requirement for this task https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/113
continue
}
cmd.Println(cnrID.String())
@ -93,7 +93,7 @@ func initContainerListContainersCmd() {
flags := listContainersCmd.Flags()
flags.StringVar(&flagVarListName, flagListName, "",
"List containers by the attribute name",
"List containers by the attribute name or by its part",
)
flags.StringVar(&flagVarListContainerOwner, flagListContainerOwner, "",
"Owner of containers (omit to use owner from private key)",