TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

Enable staticcheck in forgejo actions #490

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:feature/482-add-staticcheck into master 2023-07-07 14:04:47 +00:00
Conversation 0 Commits 1 Files changed 2 +23 -1
acid-ant commented 2023-07-05 08:58:46 +00:00
Member
Copy link

Close #482

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #482 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant force-pushed feature/482-add-staticcheck from 6a626163f3 to 811ebbe66d 2023-07-05 09:07:37 +00:00 Compare
acid-ant force-pushed feature/482-add-staticcheck from 811ebbe66d to 5a6e545955 2023-07-05 09:11:16 +00:00 Compare
acid-ant force-pushed feature/482-add-staticcheck from 5a6e545955 to a6f21cdf9a 2023-07-05 09:26:18 +00:00 Compare
acid-ant force-pushed feature/482-add-staticcheck from a6f21cdf9a to e86e3e437f 2023-07-05 11:07:24 +00:00 Compare
acid-ant force-pushed feature/482-add-staticcheck from e86e3e437f to 24759e2c4a 2023-07-05 11:46:39 +00:00 Compare
acid-ant changed title from WIP: Enable staticcheck in foregjo actions to Enable staticcheck in forgejo actions 2023-07-05 12:04:57 +00:00
acid-ant requested review from storage-core-committers 2023-07-05 12:05:05 +00:00
acid-ant requested review from storage-core-developers 2023-07-05 12:05:05 +00:00
dstepanov-yadro approved these changes 2023-07-05 13:40:04 +00:00
fyrchik reviewed 2023-07-06 08:05:30 +00:00
Makefile Outdated
@ -137,1 +137,4 @@
# Install staticcheck
staticcheck-install:
@go install honnef.co/go/tools/cmd/staticcheck@latest
fyrchik commented 2023-07-06 08:05:30 +00:00
Owner
Copy link

Why did you go with a separate target for this?

Why did you go with a separate target for this?
acid-ant commented 2023-07-06 08:20:20 +00:00
Author
Member
Copy link

It was helpful to debug. Now there are no obstacles to merge it one target. How about one target for install&run?

It was helpful to debug. Now there are no obstacles to merge it one target. How about one target for `install&run`?
dstepanov-yadro commented 2023-07-06 08:22:30 +00:00
Member
Copy link

Well, in some of my previous commits I made one target (install&run), there was a question whether it would work without the internet.

Well, in some of my previous commits I made one target (install&run), there was a question whether it would work without the internet.
fyrchik commented 2023-07-06 15:36:19 +00:00
Owner
Copy link

I mean calling go install directly vs Makefile target only for actions.
Probably it is better your way anyway.

I mean calling `go install` directly vs Makefile target only for actions. Probably it is better your way anyway.
fyrchik marked this conversation as resolved
fyrchik approved these changes 2023-07-06 15:36:30 +00:00
fyrchik reviewed 2023-07-06 15:37:26 +00:00
.forgejo/workflows/tests.yml Outdated
@ -38,6 +38,12 @@ jobs:
- name: Run tests
run: make test
- name: Install staticcheck
fyrchik commented 2023-07-06 15:37:26 +00:00
Owner
Copy link

Can we move it from tests job to lint or to a separate target? I would move to a separate job (same file, like tests + lint + staticcheck -- it could be easier to parallelize this way.

Can we move it from `tests` job to `lint` or to a separate target? I would move to a separate job (same file, like `tests` + `lint` + `staticcheck` -- it could be easier to parallelize this way.
acid-ant commented 2023-07-07 06:53:17 +00:00
Author
Member
Copy link

Moved to a separate job.

Moved to a separate job.
acid-ant force-pushed feature/482-add-staticcheck from 24759e2c4a to 6f9f610cb7 2023-07-07 05:37:56 +00:00 Compare
acid-ant force-pushed feature/482-add-staticcheck from 6f9f610cb7 to b567cb47ae 2023-07-07 05:38:20 +00:00 Compare
acid-ant changed title from Enable staticcheck in forgejo actions to WIP: Enable staticcheck in forgejo actions 2023-07-07 05:39:15 +00:00
acid-ant force-pushed feature/482-add-staticcheck from b567cb47ae to a92420f7a1 2023-07-07 05:40:17 +00:00 Compare
acid-ant changed title from WIP: Enable staticcheck in forgejo actions to Enable staticcheck in forgejo actions 2023-07-07 06:52:43 +00:00
fyrchik reviewed 2023-07-07 06:59:50 +00:00
.forgejo/workflows/tests.yml Outdated
@ -55,0 +58,4 @@
runs-on: ubuntu-latest
strategy:
matrix:
go_versions: [ '1.19', '1.20' ]
fyrchik commented 2023-07-07 06:59:50 +00:00
Owner
Copy link

The matrix is not needed here, we do not test staticcheck itself.

The matrix is not needed here, we do not test staticcheck itself.
acid-ant commented 2023-07-07 07:19:10 +00:00
Author
Member
Copy link

Updated.

Updated.
acid-ant force-pushed feature/482-add-staticcheck from a92420f7a1 to a0d51090a4 2023-07-07 07:13:07 +00:00 Compare
acid-ant scheduled this pull request to auto merge when all checks succeed 2023-07-07 09:44:03 +00:00
acid-ant requested review from storage-core-committers 2023-07-07 09:44:32 +00:00
acid-ant requested review from storage-core-developers 2023-07-07 09:44:32 +00:00
acid-ant requested review from dstepanov-yadro 2023-07-07 09:44:38 +00:00
acid-ant requested review from fyrchik 2023-07-07 09:44:40 +00:00
dstepanov-yadro approved these changes 2023-07-07 11:19:56 +00:00
fyrchik approved these changes 2023-07-07 14:04:40 +00:00
fyrchik merged commit a0d51090a4 into master 2023-07-07 14:04:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#490
No description provided.
Delete branch "acid-ant/frostfs-node:feature/482-add-staticcheck"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?