TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 95 Pull requests 4 Projects Releases 1 Activity Actions

Enable staticcheck in forgejo actions #490

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:feature/482-add-staticcheck into master 2023-07-07 14:04:47 +00:00
Conversation 0 Commits 1 Files changed 2 +23 -1
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
.forgejo/workflows/tests.yml
View file

@ -52,3 +52,21 @@ jobs:
- name: Run tests
run: go test ./... -count=1 -race
staticcheck:
name: Staticcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
fyrchik commented 2023-07-07 06:59:50 +00:00
Outdated
Review
Copy link

The matrix is not needed here, we do not test staticcheck itself.

The matrix is not needed here, we do not test staticcheck itself.
acid-ant commented 2023-07-07 07:19:10 +00:00
Outdated
Review
Copy link

Updated.

Updated.
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: '1.20'
cache: true
- name: Install staticcheck
run: make staticcheck-install
- name: Run staticcheck
run: make staticcheck-run

6
Makefile
View file

@ -135,8 +135,12 @@ pre-commit-run:
lint:
@golangci-lint --timeout=5m run
# Install staticcheck
staticcheck-install:
@go install honnef.co/go/tools/cmd/staticcheck@latest
fyrchik marked this conversation as resolved Outdated
fyrchik commented 2023-07-06 08:05:30 +00:00
Outdated
Review
Copy link

Why did you go with a separate target for this?

Why did you go with a separate target for this?
acid-ant commented 2023-07-06 08:20:20 +00:00
Outdated
Review
Copy link

It was helpful to debug. Now there are no obstacles to merge it one target. How about one target for install&run?

It was helpful to debug. Now there are no obstacles to merge it one target. How about one target for `install&run`?
dstepanov-yadro commented 2023-07-06 08:22:30 +00:00
Outdated
Review
Copy link

Well, in some of my previous commits I made one target (install&run), there was a question whether it would work without the internet.

Well, in some of my previous commits I made one target (install&run), there was a question whether it would work without the internet.
fyrchik commented 2023-07-06 15:36:19 +00:00
Outdated
Review
Copy link

I mean calling go install directly vs Makefile target only for actions.
Probably it is better your way anyway.

I mean calling `go install` directly vs Makefile target only for actions. Probably it is better your way anyway.
# Run staticcheck
staticcheck:
staticcheck-run:
@staticcheck ./...
# Run linters in Docker