TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 106 Pull requests 12 Projects Releases 2 Activity Actions

cli: Fix object nodes command #499

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/object-nodes-addresses into master 2023-07-10 12:02:21 +00:00
Conversation 0 Commits 1 Files changed 1 +7 -17
dstepanov-yadro commented 2023-07-07 08:14:02 +00:00
Member
Copy link

Do not fail if client creation failed.
Use external addresses to create the client too.
Changed print name: use public key as node ID like the other commands.

Closes #476

Do not fail if client creation failed. Use external addresses to create the client too. Changed print name: use public key as node ID like the other commands. Closes #476
requested reviews from storage-core-committers, storage-core-developers 2023-07-07 08:16:19 +00:00
ale64bit approved these changes 2023-07-07 09:09:56 +00:00
aarifullin approved these changes 2023-07-07 09:23:32 +00:00
aarifullin left a comment
Member
Copy link

LGTM

LGTM
acid-ant approved these changes 2023-07-07 09:55:11 +00:00
fyrchik reviewed 2023-07-07 14:55:56 +00:00
cmd/frostfs-cli/modules/object/nodes.go Outdated
@ -359,0 +349,4 @@
func getNodeAddressToPrint(n netmapSDK.NodeInfo) string {
nodeAttrValue := ""
n.IterateAttributes(func(key, value string) {
if key == "Node" {
fyrchik commented 2023-07-07 14:54:53 +00:00
Owner
Copy link

It is note well-known, what about providing it via an argument?

It is note well-known, what about providing it via an argument?
dstepanov-yadro commented 2023-07-07 15:53:56 +00:00
Author
Member
Copy link

Now node's public key prints as NodeID

Now node's public key prints as NodeID
dstepanov-yadro force-pushed fix/object-nodes-addresses from 6e246af01b to c9fee99f92 2023-07-07 15:53:12 +00:00 Compare
dstepanov-yadro force-pushed fix/object-nodes-addresses from c9fee99f92 to 040a623d39 2023-07-10 06:59:08 +00:00 Compare
fyrchik approved these changes 2023-07-10 11:58:49 +00:00
fyrchik merged commit 040a623d39 into master 2023-07-10 12:02:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ale64bit
aarifullin
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#499
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/object-nodes-addresses"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?