Fix TestEvacuateShard #508

Merged

fyrchik merged 1 commits from dstepanov-yadro/frostfs-node:fix/evacuate_test into master

2023-07-17 10:24:07 +00:00

dstepanov-yadro commented

2023-07-11 13:15:13 +00:00

Collaborator

Closes #382

Looks like pool.Submit returns ErrPoolOverload. So I have increased pool size and added logging.

Closes #382 Looks like `pool.Submit` returns `ErrPoolOverload`. So I have increased pool size and added logging.

dstepanov-yadro force-pushed fix/evacuate_test from b97fe930b4 to 7823034ae6

2023-07-11 13:36:23 +00:00

Compare

dstepanov-yadro force-pushed fix/evacuate_test from 7823034ae6 to 4ab83b3cf5

2023-07-12 13:55:33 +00:00

Compare

dstepanov-yadro force-pushed fix/evacuate_test from 4ab83b3cf5 to afbec1c232

2023-07-12 13:56:12 +00:00

Compare

dstepanov-yadro force-pushed fix/evacuate_test from afbec1c232 to 16e210de9a

2023-07-12 13:56:54 +00:00

Compare

dstepanov-yadro changed title from ~~WIP: Fix TestEvacuateShard~~ to Fix TestEvacuateShard

2023-07-12 13:57:32 +00:00

dstepanov-yadro requested review from storage-core-committers 2023-07-12 13:57:38 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-07-12 13:57:38 +00:00

fyrchik commented

2023-07-13 06:50:32 +00:00

Owner

If pool.Submit returns an error, a nice addition to your solution is to use WithBlocking(true) -- just block on Submit irregardless of how big the pool is.

If `pool.Submit` returns an error, a nice addition to your solution is to use `WithBlocking(true)` -- just block on Submit irregardless of how big the pool is.

fyrchik approved these changes 2023-07-13 10:50:34 +00:00

dstepanov-yadro commented

2023-07-13 12:18:30 +00:00

Poster

Collaborator

If pool.Submit returns an error, a nice addition to your solution is to use WithBlocking(true) -- just block on Submit irregardless of how big the pool is.

The pool is used for put objects. It seems that this is too important change for the flaky test.

> If `pool.Submit` returns an error, a nice addition to your solution is to use `WithBlocking(true)` -- just block on Submit irregardless of how big the pool is. The pool is used for put objects. It seems that this is too important change for the flaky test.

fyrchik commented

2023-07-15 09:56:54 +00:00

Owner

I mean 10 is a magic number to me, it is not obvious why the test is made "non-flaky" vs "less flaky" with this change.

dstepanov-yadro force-pushed fix/evacuate_test from 16e210de9a to 2106a0fcb7

2023-07-17 07:03:30 +00:00

Compare

dstepanov-yadro force-pushed fix/evacuate_test from 2106a0fcb7 to 05e46b9ec1

2023-07-17 07:05:43 +00:00

Compare

dstepanov-yadro commented

2023-07-17 07:07:25 +00:00

Poster

Collaborator

I mean 10 is a magic number to me, it is not obvious why the test is made "non-flaky" vs "less flaky" with this change.

Ok. I think there is an error with pool size = 1. So I just dropped WithPoolSize option, default value (20) will be used.

> I mean 10 is a magic number to me, it is not obvious why the test is made "non-flaky" vs "less flaky" with this change. Ok. I think there is an error with pool size = 1. So I just dropped WithPoolSize option, default value (20) will be used.

👍 1