TrueCloudLab/frostfs-node

Tree service config: add examples and unit tests #515

Merged

fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/missed-config-examples into master

2023-07-17 08:23:30 +00:00

dstepanov-yadro commented

2023-07-12 12:41:57 +00:00

Member

Add examples and unit tests for tree.authorized_keys section.

Closes #497

Add examples and unit tests for `tree.authorized_keys` section. Closes #497

requested reviews from storage-core-committers, storage-core-developers

2023-07-12 12:42:48 +00:00

fyrchik reviewed 2023-07-12 14:36:57 +00:00

cmd/frostfs-node/config/tree/config_test.go Outdated

					
				@ -34,6 +44,7 @@ func TestTreeSection(t *testing.T) {

						require.Equal(t, 32, treeSec.ReplicationWorkerCount())

						require.Equal(t, 5*time.Second, treeSec.ReplicationTimeout())

						require.Equal(t, time.Hour, treeSec.SyncInterval())

						require.ElementsMatch(t, expectedKeys, treeSec.AuthorizedKeys())

fyrchik commented

2023-07-12 14:36:57 +00:00

Owner

Config wrappers are thin, we guarantee the order, just Equal?

Config wrappers are thin, we guarantee the order, just `Equal`?

dstepanov-yadro commented

2023-07-12 14:55:08 +00:00

Author

Member

fixed

fixed

dstepanov-yadro force-pushed fix/missed-config-examples from 0f730d04f0 to 2c2e3184ed

2023-07-12 14:55:00 +00:00

Compare

ale64bit approved these changes 2023-07-13 13:45:10 +00:00

fyrchik approved these changes 2023-07-17 08:23:15 +00:00

fyrchik merged commit d8e37a827f into master

2023-07-17 08:23:30 +00:00

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#515

No description provided.