Refactor replicator #517

dstepanov-yadro · 2023-07-12T15:05:28Z

dstepanov-yadro commented

2023-07-12 15:05:28 +00:00

Now remote target tries put object with single request. If it is not possible or PutSingle RPC not implemented, put with stream is used.
Capacity rebalance removed
Added trace for replicator task handler

Closes #463

* Now remote target tries put object with single request. If it is not possible or PutSingle RPC not implemented, put with stream is used. * Capacity rebalance removed * Added trace for replicator task handler Closes #463

dstepanov-yadro requested review from storage-core-committers 2023-07-13 12:20:54 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-07-13 12:20:54 +00:00

dstepanov-yadro changed title from ~~WIP: Refactor replicator~~ to Refactor replicator

2023-07-13 12:20:59 +00:00

ale64bit approved these changes 2023-07-13 13:52:54 +00:00

pkg/services/object/internal/client/client.go Outdated

													
				@ -452,0 +460,4 @@

					objID, isSet := prm.obj.ID()

					if !isSet {

						return nil, fmt.Errorf("missing object id")

ale64bit commented

2023-07-13 13:48:45 +00:00

errors.New?

`errors.New`?

dstepanov-yadro commented

2023-07-14 07:38:41 +00:00

Poster

fixed

ale64bit marked this conversation as resolved

pkg/services/object/internal/client/client.go Outdated

													
				@ -452,0 +489,4 @@

					if err == nil {

						err = apistatus.ErrFromStatus(res.Status())

					} else {

ale64bit commented

2023-07-13 13:52:06 +00:00

discussed offline

dstepanov-yadro commented

2023-07-14 07:38:47 +00:00

Poster

fixed

ale64bit marked this conversation as resolved

dstepanov-yadro force-pushed feat/replicator-put-single from ff17b9726d to 1364113f08

2023-07-14 07:38:34 +00:00

Compare

fyrchik reviewed 2023-07-15 10:06:17 +00:00

fyrchik left a comment

There is a typo in the policIer in the commit message
In the commit we remove rebalancing logic, could you mention the reasons in the commit message? Also, do you have some other ideas for this in mind?

1. There is a typo in the `policIer` in the commit message 2. In the commit we remove rebalancing logic, could you mention the reasons in the commit message? Also, do you have some other ideas for this in mind?

pkg/services/object/put/remote.go Outdated

													
				@ -64,2 +66,4 @@

					prm.SetObject(t.obj)

					_, objectIDSet := t.obj.ID()

					if objectIDSet {

fyrchik commented

2023-07-15 10:01:15 +00:00

remoteTarget is used by node only, so I would expect only prepared objects here.
Can this condition be false?

`remoteTarget` is used by node only, so I would expect only prepared objects here. Can this condition be false?

dstepanov-yadro commented

2023-07-17 08:38:31 +00:00

Poster

fixed

dstepanov-yadro force-pushed feat/replicator-put-single from 1364113f08 to e39a9c9c68

2023-07-17 08:38:16 +00:00

Compare

fyrchik approved these changes 2023-07-18 10:51:55 +00:00

fyrchik merged commit f0355a453e into master

2023-07-18 10:52:13 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#517