[#479] Fix writecache fstree flush premature ctx cancel #518

Merged

fyrchik merged 1 commit from ale64bit/frostfs-node:fix/479-wc-fstree-flush into master

2023-07-15 09:55:36 +00:00

ale64bit commented

2023-07-13 09:15:52 +00:00

Member

The context is guaranteed to be canceled if Close is called, since the waitgroup is waited upon there.

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Closes #479

The context is guaranteed to be canceled if `Close` is called, since the waitgroup is waited upon there. Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Closes #479

ale64bit requested review from storage-core-committers 2023-07-13 09:16:09 +00:00

ale64bit requested review from storage-core-developers 2023-07-13 09:16:09 +00:00

fyrchik approved these changes 2023-07-13 10:47:34 +00:00

fyrchik commented

2023-07-14 07:21:22 +00:00

Owner

writecache: prefix to the commit message?

`writecache:` prefix to the commit message?

ale64bit force-pushed fix/479-wc-fstree-flush from 3e5af91864 to 11027945d8

2023-07-14 07:26:20 +00:00

Compare

ale64bit commented

2023-07-14 07:28:11 +00:00

Author

Member

writecache: prefix to the commit message?

done

<rant>
This practice seems rather futile. It's not enforced anyhow. It's not used in any kind of automation. There's not even an authoritative list of the valid component names or prefixes. What are we gaining with this?
</rant>

> `writecache:` prefix to the commit message? done `<rant>` This practice seems rather futile. It's not enforced anyhow. It's not used in any kind of automation. There's not even an authoritative list of the valid component names or prefixes. What are we gaining with this? `</rant>`

fyrchik commented

2023-07-15 09:55:09 +00:00

Owner

Uniform commit messages across the codebase.
It is useful for reading code and searching for commits.

We could change this, but anyway, please, let's discuss it first, so everyone is aware.

Uniform commit messages across the codebase. It is useful for reading code and searching for commits. We could change this, but anyway, please, let's discuss it first, so everyone is aware.

fyrchik approved these changes 2023-07-15 09:55:26 +00:00