Refactor UX for bearer create command #523

dstepanov-yadro · 2023-07-14T09:03:31Z

dstepanov-yadro commented

2023-07-14 09:03:31 +00:00

If issuedAt or notValidBefore are not specified, then use current epoch value.

Also added RPC endpoint value check.

Closes #512

If `issuedAt` or `notValidBefore` are not specified, then use current epoch value. Also added RPC endpoint value check. Closes #512

dstepanov-yadro force-pushed fix/cli-bearer-create from cb6d06ce7c to 1137d26591

2023-07-14 09:05:46 +00:00

Compare

ale64bit reviewed 2023-07-14 09:18:27 +00:00

cmd/frostfs-cli/modules/bearer/create.go Outdated

													
				@ -68,3 +66,3 @@

					commonCmd.ExitOnErr(cmd, "can't parse --"+notValidBeforeFlag+" flag: %w", err)

					if iatRelative || expRelative || nvbRelative {

					iatMissing := !flagSpecified(cmd, issuedAtFlag)

ale64bit commented

2023-07-14 09:16:38 +00:00

if this util function is used only negated, wasn't it easier to not have it and instead do

iatMissing := cmd.Flags().Lookup(issuedAtFlag) == nil

and so on?

if this util function is used only negated, wasn't it easier to not have it and instead do ```go iatMissing := cmd.Flags().Lookup(issuedAtFlag) == nil ``` and so on?

dstepanov-yadro commented

2023-07-14 09:38:14 +00:00

Poster

cmd.Flags().Lookup(issuedAtFlag) returns not nil, if flag with such name defined by code. We must to check Changed too:

func flagSpecified(cmd *cobra.Command, flag string) bool {
	v := cmd.Flags().Lookup(flag)
	return v != nil && v.Changed
}

`cmd.Flags().Lookup(issuedAtFlag)` returns not nil, if flag with such name defined by code. We must to check `Changed` too: ``` func flagSpecified(cmd *cobra.Command, flag string) bool { v := cmd.Flags().Lookup(flag) return v != nil && v.Changed } ```

👍 1

ale64bit marked this conversation as resolved

ale64bit approved these changes 2023-07-14 10:45:08 +00:00

fyrchik requested changes 2023-07-15 09:50:34 +00:00

cmd/frostfs-cli/modules/bearer/create.go Outdated

													
				@ -69,2 +67,3 @@

					if iatRelative || expRelative || nvbRelative {

					iatMissing := !flagSpecified(cmd, issuedAtFlag)

					nvbMissing := !flagSpecified(cmd, notValidBeforeFlag)