TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

Fix datarace in writecache tests #548

Merged
fyrchik merged 2 commits from fyrchik/frostfs-node:fix-writecache into master 2023-07-29 10:57:27 +00:00
Conversation 0 Commits 2 Files Changed 1
fyrchik commented 2023-07-27 16:59:39 +00:00
Owner

Close #541

It is the most likely reason, let's wait and see.

Close #541 It is the most likely reason, let's wait and see.
fyrchik added 2 commits 2023-07-27 16:59:41 +00:00
9ec52463dc [#541] writecache/test: Remove initWC() 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Build / Build Components (1.19) (pull_request) Successful in 3m45s Details
Tests and linters / Lint (pull_request) Successful in 5m55s Details
Build / Build Components (1.20) (pull_request) Successful in 6m53s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 3m59s Details
Tests and linters / Tests with -race (pull_request) Successful in 6m9s Details
Tests and linters / Tests (1.19) (pull_request) Successful in 12m7s Details
Tests and linters / Staticcheck (pull_request) Successful in 4m13s Details
Vulncheck / Vulncheck (pull_request) Successful in 3m55s Details
2f4483b224 [#541] writecache/test: Close writecache on exit 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2023-07-27 16:59:51 +00:00
fyrchik requested review from storage-core-developers 2023-07-27 16:59:52 +00:00
ale64bit approved these changes 2023-07-28 07:52:19 +00:00
dstepanov-yadro approved these changes 2023-07-28 12:51:33 +00:00
fyrchik merged commit ec8b4fdc48 into master 2023-07-29 10:57:27 +00:00
fyrchik deleted branch fix-writecache 2023-07-29 10:57:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ale64bit
dstepanov-yadro
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#548
There is no content yet.
Delete Branch "fyrchik/frostfs-node:fix-writecache"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?