[#550] cli: make get-op-log meta pretty formatted #551

aarifullin · 2023-08-01T10:09:14Z

aarifullin commented

2023-08-01 10:09:14 +00:00

Close #550

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Close #550 Signed-off-by: Airat Arifullin a.arifullin@yadro.com

aarifullin added the

enhancement

label 2023-08-01 10:09:14 +00:00

aarifullin force-pushed feature/5177-get_op_log_meta from 73c71a5f22 to 7e8361e0eb

2023-08-01 10:12:51 +00:00

Compare

aarifullin changed title from ~~[#XX] frostfs-cli: make get-op-log meta pretty formatted~~ to [#551] frostfs-cli: make get-op-log meta pretty formatted

2023-08-01 10:12:54 +00:00

aarifullin requested review from storage-core-committers 2023-08-01 10:13:19 +00:00

aarifullin requested review from storage-core-developers 2023-08-01 10:13:20 +00:00

aarifullin force-pushed feature/5177-get_op_log_meta from 7e8361e0eb to 2831515466

2023-08-01 10:17:08 +00:00

Compare

aarifullin force-pushed feature/5177-get_op_log_meta from 2831515466 to 3a7f309613

2023-08-01 10:24:14 +00:00

Compare

dstepanov-yadro commented

2023-08-01 10:30:31 +00:00

An example of output would be helpful to understand changes.

fyrchik commented

2023-08-01 10:40:55 +00:00

Not so long ago we agreed to use cli: instead of the frostfs-cli: in the commit messages, could you fix it here?

Not so long ago we agreed to use `cli:` instead of the `frostfs-cli:` in the commit messages, could you fix it here?

fyrchik approved these changes 2023-08-01 10:41:27 +00:00

aarifullin force-pushed feature/5177-get_op_log_meta from 3a7f309613 to 28f4b69724

2023-08-01 10:42:29 +00:00

Compare

aarifullin changed title from ~~[#551] frostfs-cli: make get-op-log meta pretty formatted~~ to [#551] cli: make get-op-log meta pretty formatted

2023-08-01 10:42:35 +00:00

aarifullin commented

2023-08-01 10:42:46 +00:00

Not so long ago we agreed to use cli: instead of the frostfs-cli: in the commit messages, could you fix it here?

Sorry, fixed!

> Not so long ago we agreed to use `cli:` instead of the `frostfs-cli:` in the commit messages, could you fix it here? Sorry, fixed!

aarifullin commented

2023-08-01 10:43:48 +00:00

An example of output would be helpful to understand changes.

It was:

Parent ID:  0
        Child ID:  3013597190708019803
        Meta: OID,EMFX3yYuMR8mnhi8wz2hD6GaQxDjnoH4oYx4dTXDR5gFileNametextSize4387ETag@fdbf9f0e85848d6554dceb84bf463717cnode_exporter) for this project. I

and now it is:

Parent ID:  0
        Child ID:  3013597190708019803
        Meta:
                Time: 3
                OID: EMFX3yYuMR8mnhi8wz2hD6GaQxDjnoH4oYx4dTXDR5g7
                FileName: text
                Size: 4387
                ETag: fdbf9f0e85848d6554dceb84bf463717cac0432312f15ff4596e51eec9ec08e3

> An example of output would be helpful to understand changes. It was: ``` Parent ID: 0 Child ID: 3013597190708019803 Meta: OID,EMFX3yYuMR8mnhi8wz2hD6GaQxDjnoH4oYx4dTXDR5gFileNametextSize4387ETag@fdbf9f0e85848d6554dceb84bf463717cnode_exporter) for this project. I ``` and now it is: ``` Parent ID: 0 Child ID: 3013597190708019803 Meta: Time: 3 OID: EMFX3yYuMR8mnhi8wz2hD6GaQxDjnoH4oYx4dTXDR5g7 FileName: text Size: 4387 ETag: fdbf9f0e85848d6554dceb84bf463717cac0432312f15ff4596e51eec9ec08e3 ```

👍 1

acid-ant approved these changes 2023-08-01 10:46:32 +00:00

dstepanov-yadro approved these changes 2023-08-01 10:51:21 +00:00

fyrchik reviewed 2023-08-01 13:39:16 +00:00

cmd/frostfs-cli/modules/tree/get_op_log.go Outdated

					
				@ -79,0 +81,4 @@

						err = m.FromBytes(o.GetMeta())

						commonCmd.ExitOnErr(cmd, "could not unmarshal meta: %w", err)

						cmd.Printf("\tMeta:\n")

						cmd.Printf("\t\tTime: %d\n", m.Time)