writecache: Fix metrics and bolt delete #571
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#571
Loading…
Reference in a new issue
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/wc_metrics"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #563
Estimate cache size after delete objects to update metric.
Fix small object deletion: small objects were never logically deleted from the database.
Do not count bbolt DB file as FSTree object.
@ -88,3 +79,4 @@
)
c.estimateCacheSize()
}
if err != nil {
} else {
?fixed
The problems was with counters, not with the deletion itself. Can we describe it in the commit message?
@ -68,6 +68,9 @@ func (c *cache) initCounters() error {
if err != nil {
return fmt.Errorf("could not read write-cache FS counter: %w", err)
}
if inFS > 0 {
This is worth a separate commit
This change also applies to metrics, I disagree.
These are 2 separate problems with metrics (definitely with different descriptions)
I don't insist, though.
6a2e554ea5
to44e92f06e0