writecache: Fix metrics and bolt delete #571

dstepanov-yadro · 2023-08-07T09:12:54Z

dstepanov-yadro commented

2023-08-07 09:12:54 +00:00

Closes #563

Estimate cache size after delete objects to update metric.
Fix small object deletion: small objects were never logically deleted from the database.
Do not count bbolt DB file as FSTree object.

Closes #563 Estimate cache size after delete objects to update metric. Fix small object deletion: small objects were never _logically_ deleted from the database. Do not count bbolt DB file as FSTree object.

dstepanov-yadro requested review from storage-core-committers 2023-08-07 09:13:05 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-08-07 09:13:05 +00:00

ale64bit approved these changes 2023-08-07 09:26:00 +00:00

pkg/local_object_storage/writecache/writecachebbolt/storage.go Outdated

													
				@ -88,3 +79,4 @@

						)

						c.estimateCacheSize()

					}

					if err != nil {

ale64bit commented

2023-08-07 09:24:32 +00:00

} else { ?

`} else {` ?

dstepanov-yadro commented

2023-08-07 10:33:29 +00:00

Poster

fixed

ale64bit marked this conversation as resolved

fyrchik commented

2023-08-07 09:46:40 +00:00

The problems was with counters, not with the deletion itself. Can we describe it in the commit message?

👍 1

fyrchik reviewed 2023-08-07 09:46:55 +00:00

pkg/local_object_storage/writecache/writecachebbolt/state.go Outdated

													
				@ -68,6 +68,9 @@ func (c *cache) initCounters() error {

					if err != nil {

						return fmt.Errorf("could not read write-cache FS counter: %w", err)

					}

					if inFS > 0 {