[#576] Set SyncWrites for badger writecache by default #582

ale64bit · 2023-08-09T08:29:51Z

ale64bit commented

2023-08-09 08:29:51 +00:00

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Closes #576

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Closes #576

ale64bit added 1 commit 2023-08-09 08:29:52 +00:00

[#576 ] Set SyncWrites for badger writecache by default

Build / Build Components (1.19) (pull_request) Failing after 3s

Details

Build / Build Components (1.20) (pull_request) Failing after 2s

Details

Tests and linters / Tests (1.19) (pull_request) Failing after 3s

Details

Tests and linters / Tests with -race (pull_request) Failing after 3s

Details

Tests and linters / Lint (pull_request) Failing after 12s

Details

Tests and linters / Staticcheck (pull_request) Failing after 3s

Details

Vulncheck / Vulncheck (pull_request) Successful in 5m46s

Details

Tests and linters / Tests (1.20) (pull_request) Successful in 11m37s

Details

ae322e9f73

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>

ale64bit requested review from storage-core-committers 2023-08-09 08:30:03 +00:00

ale64bit requested review from storage-core-developers 2023-08-09 08:30:04 +00:00

dstepanov-yadro approved these changes 2023-08-09 08:53:41 +00:00

fyrchik reviewed 2023-08-09 09:05:02 +00:00

pkg/local_object_storage/writecache/writecachebadger/options.go

					
				@ -113,4 +110,0 @@

				// Note, that we use this flag for FSTree only and DO NOT use it for a bolt DB because

				// we cannot yet properly handle the corrupted database during the startup. This SHOULD NOT

				// be relied upon and may be changed in future.

				func WithNoSync(noSync bool) Option {

fyrchik commented

2023-08-09 09:05:02 +00:00

Why remove this setting? It could be useful to get some baselines, we can just use WithSyncWrites(!opts.noSync)

Why remove this setting? It _could_ be useful to get some baselines, we can just use `WithSyncWrites(!opts.noSync)`

ale64bit commented

2023-08-09 09:10:59 +00:00

This is only used for fstree in the bbolt cache. There's no fstree in badger cache so it seems quite misleading to have the same parameter control different settings for each cache, especially one that can lead to subtle mistakes.

👍 1